fix: parse number from redis result

Author: velopert

src/index.server.ts

@@ -11,6 +11,8 @@ console.log(process.env.REACT_APP_SSR);
 const app = new Koa();
 const router = new Router();
 
+app.proxy = true;
+
 app.use(
   serve(path.resolve('./build'), {
     index: false,

src/server/rateLimitMiddleware.ts

@@ -1,6 +1,13 @@
 import { Middleware } from 'koa';
 import { redis } from './CacheManager';
 
+const parseNumber = (value: string | null) => {
+  if (value === null) return null;
+  const parsed = parseInt(value, 10);
+  if (isNaN(parsed)) return null;
+  return parsed;
+};
+
 const rateLimitMiddleware: Middleware = async (ctx, next) => {
   const ip = ctx.request.ips.slice(-1)[0] || ctx.request.ip;
 
@@ -9,14 +16,16 @@ const rateLimitMiddleware: Middleware = async (ctx, next) => {
 
   const blocked = await redis.get(blockedKey);
 
-  if (blocked) {
+  if (parseNumber(blocked) === 1) {
     ctx.status = 429;
     ctx.body = { msg: 'Too many request' };
     return;
   }
   const exists = await redis.get(key);
+  const parsed = parseNumber(exists);
 
-  if (typeof exists === 'number' && exists > 100) {
+  if (parsed !== null && parsed >= 100) {
+    console.log(`Blocking... ${ip} - ${exists}`);
     await redis.set(blockedKey, 1);
     await redis.expire(blockedKey, 300);
     ctx.status = 429;

src/server/ssrMiddleware.ts

@@ -2,13 +2,14 @@ import { Middleware } from 'koa';
 import serverRender from './serverRender';
 
 const ssrMiddleware: Middleware = async (ctx, next) => {
+  const ip = ctx.request.ips.slice(-1)[0] || ctx.request.ip;
   // redirect to v3 for user posts tab
   if (/^\/@([a-z0-9]+)$/.test(ctx.path)) {
     ctx.redirect(`${ctx.path}/posts`);
     return;
   }
 
-  console.log('>> ' + ctx.url);
+  console.log(ip + ' >> ' + ctx.url);
 
   try {
     const result = await serverRender({
@@ -26,7 +27,7 @@ const ssrMiddleware: Middleware = async (ctx, next) => {
   } catch (e) {
     ctx.throw(500, e as any);
   }
-  console.log('<< ' + ctx.url);
+  console.log(ip + '<< ' + ctx.url);
 };
 
 export default ssrMiddleware;