Skip to content

Conversation

@jeehoonkang
Copy link
Contributor

  • This patch is modifications accumulated during simplberry development.
  • Notable changes are:
  • This commit is not production-ready: containing a lot of comments, etc. Let's discuss on the change, and clean the code and merge.

@dgarbuzov
Copy link
Contributor

We're discussing the issues with extraction in another thread, and I think we talked about adding the tag checking to stores on Skype. That and the update to malloc I think are correct w.r.t the semantics of LLVM/C, respectively.

The apparent typo in callFree__extcall_properties is troubling. I'm still not sure I understand external_intrinsics.v -- why does a call to malloc/free result in an empty trace?

Nitpicking:

  • it would be nice to put the extracted files in a separate directory. The only way I know to do this is to call Cd "./otherdir" in the extraction script.
  • Removing commented code prior to committing would make the diffs slightly easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants