Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page NPM dependency [help-wanted] #74

Open
dr-dimitru opened this issue Jan 25, 2020 · 1 comment · May be fixed by #75
Open

Update page NPM dependency [help-wanted] #74

dr-dimitru opened this issue Jan 25, 2020 · 1 comment · May be fixed by #75

Comments

@dr-dimitru
Copy link
Member

Shout out to all developers, help wanted to update page NPM package dependency to the latest release (as time of posting v1.11.5);

Using any version newer than v1.9.0 won't pass auto-tests. Multiple tests are failing with weird behavior like reloading page repeatedly or generating wrong urls like: /flow/flow//flow/flow/flow/flow//flow/flow//flow/flow//flow/flow/flow/flow//flow/flow/flow/flow//flow/flow/flow/flow//flow/flow//flow/flow//flow/flow/flow/flow//flow/XP65zT6zcisKT8aab

This is not today's discovery, I've trying to find an issue during last year. Hope someone from community worked directly with page package and would suggest or send a PR to fix current issue. Similar to #73

@jankapunkt jankapunkt linked a pull request Feb 23, 2020 that will close this issue
3 tasks
@jankapunkt
Copy link

I checked into this and found some related issues in the code but the PR #75 is still work in progress. I did not find out, where exactly the exit trigger is fired in order to continue to find the related code in the page package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants