-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expr
method signatures
#3600
base: main
Are you sure you want to change the base?
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a60e8cc - Browse repository at this point
Copy the full SHA a60e8ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7dca1c - Browse repository at this point
Copy the full SHA e7dca1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49d328d - Browse repository at this point
Copy the full SHA 49d328dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11d759d - Browse repository at this point
Copy the full SHA 11d759dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0109c8c - Browse repository at this point
Copy the full SHA 0109c8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f736be - Browse repository at this point
Copy the full SHA 1f736beView commit details -
Configuration menu - View commit details
-
Copy full SHA for e26083a - Browse repository at this point
Copy the full SHA e26083aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bb4c27 - Browse repository at this point
Copy the full SHA 6bb4c27View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1bf708 - Browse repository at this point
Copy the full SHA d1bf708View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e62bd9 - Browse repository at this point
Copy the full SHA 3e62bd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67c6a1e - Browse repository at this point
Copy the full SHA 67c6a1eView commit details -
feat(DRAFT): Adds
VegaExprNode.to_signature
- Only the most common case - no docs - No method body
Configuration menu - View commit details
-
Copy full SHA for 815404e - Browse repository at this point
Copy the full SHA 815404eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51e569e - Browse repository at this point
Copy the full SHA 51e569eView commit details -
feat(DRAFT): Add
render_expr_method
Currently just collects the pieces, but doesn't render the final str
Configuration menu - View commit details
-
Copy full SHA for b3006bc - Browse repository at this point
Copy the full SHA b3006bcView commit details -
refactor:
FunctionExpression
->Expression
for annotation onlyAlso renamed constant `EXPR_ANNOTATION` -> `INPUT_ANNOTATION`
Configuration menu - View commit details
-
Copy full SHA for 54f7db0 - Browse repository at this point
Copy the full SHA 54f7db0View commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 328cc98 - Browse repository at this point
Copy the full SHA 328cc98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e1897d - Browse repository at this point
Copy the full SHA 6e1897dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb33243 - Browse repository at this point
Copy the full SHA fb33243View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ce1567 - Browse repository at this point
Copy the full SHA 1ce1567View commit details -
feat(DRAFT): Full
expr
module generation- Contains all the functionality - Needs a lot of tidying up
Configuration menu - View commit details
-
Copy full SHA for b88221f - Browse repository at this point
Copy the full SHA b88221fView commit details
Commits on Sep 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0a09936 - Browse repository at this point
Copy the full SHA 0a09936View commit details -
feat: Split doc summary, wrap body
- Uses the same config as `indent_docstring` - Can't truly be `numpydoc` though without a parameters section
Configuration menu - View commit details
-
Copy full SHA for 9377598 - Browse repository at this point
Copy the full SHA 9377598View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e88cd2 - Browse repository at this point
Copy the full SHA 8e88cd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5b3717 - Browse repository at this point
Copy the full SHA f5b3717View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ec0505 - Browse repository at this point
Copy the full SHA 7ec0505View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 29f08dc - Browse repository at this point
Copy the full SHA 29f08dcView commit details -
feat: Replace all
Vega
function refs in code blocks- Renamed `name_safe` -> `title` - Perform an eager pass to extract replacement pairs #3600 (comment)
Configuration menu - View commit details
-
Copy full SHA for f6cc776 - Browse repository at this point
Copy the full SHA f6cc776View commit details -
docs: Update doc for
is_overloaded
I've identified multiple kinds of overloads. If we want to further improve accuracy, then these would need to be considered separately
Configuration menu - View commit details
-
Copy full SHA for 321a0cd - Browse repository at this point
Copy the full SHA 321a0cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90f7b0a - Browse repository at this point
Copy the full SHA 90f7b0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36ac45a - Browse repository at this point
Copy the full SHA 36ac45aView commit details -
refactor: Simplify
VegaExprNode._split_signature_tokens
- Separates the token vs string iteration - Improve doc, w/ example
Configuration menu - View commit details
-
Copy full SHA for 56dfa27 - Browse repository at this point
Copy the full SHA 56dfa27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cab1a1 - Browse repository at this point
Copy the full SHA 9cab1a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 283eff6 - Browse repository at this point
Copy the full SHA 283eff6View commit details
Commits on Sep 24, 2024
-
- Renaming - Allow refreshing on any call - Auto refresh if first call did not
Configuration menu - View commit details
-
Copy full SHA for 497f2fd - Browse repository at this point
Copy the full SHA 497f2fdView commit details -
- Already general enough to be used in other areas of `tools`. - E.g. for `vega-lite` docs using `true`, `false`, `null` -> `True`, `False`, `None`
Configuration menu - View commit details
-
Copy full SHA for b0b1952 - Browse repository at this point
Copy the full SHA b0b1952View commit details -
refactor: Replace
VegaExprNode.parameter_names
property with a filt……erable iterator
Configuration menu - View commit details
-
Copy full SHA for 2d5271e - Browse repository at this point
Copy the full SHA 2d5271eView commit details -
refactor: Tidy up
"clamprange"
->"clampRange"
special case- Was previously being handled in multiple places - Now the correct name is set during the first access to `self.name`
Configuration menu - View commit details
-
Copy full SHA for 849f428 - Browse repository at this point
Copy the full SHA 849f428View commit details -
refactor: Reorder
with_
methods, add docsLittle bit easier to see how they relate
Configuration menu - View commit details
-
Copy full SHA for bed8d0f - Browse repository at this point
Copy the full SHA bed8d0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 264e4a6 - Browse repository at this point
Copy the full SHA 264e4a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c24e46 - Browse repository at this point
Copy the full SHA 7c24e46View commit details -
feat: Adds initial
vega_expr
apiThere are more things I want to change, but ideally keep `write_expr_module` consistent
Configuration menu - View commit details
-
Copy full SHA for 051bcb2 - Browse repository at this point
Copy the full SHA 051bcb2View commit details -
build: run
generate-schema-wrapper
- Need to do some experimenting with a new test suite for `expr` - Temporarily isolating this to `expr.dummy.py` - Will later replace `expr.__init__.py`
Configuration menu - View commit details
-
Copy full SHA for 5e75051 - Browse repository at this point
Copy the full SHA 5e75051View commit details -
chore: Add note to
test_expr.py
Need to make a change here to start a GH thread
Configuration menu - View commit details
-
Copy full SHA for 222d03e - Browse repository at this point
Copy the full SHA 222d03eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7a47a5 - Browse repository at this point
Copy the full SHA f7a47a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9238fb6 - Browse repository at this point
Copy the full SHA 9238fb6View commit details
Commits on Sep 25, 2024
-
- Combined some single use functions - `signature_n_params` - Collect the signature here, since the function is prefixed with `signature_` - Use a cheaper method of calculating number of target params - Reordered, renamed, prepare `test_expr_methods` for the new `expr` type #3600 (comment)
Configuration menu - View commit details
-
Copy full SHA for 7311fdf - Browse repository at this point
Copy the full SHA 7311fdfView commit details -
fix: Move some imports to
TYPE_CHECKING
block`ruff` was warning that `TYPE_CHECKING` was unused
Configuration menu - View commit details
-
Copy full SHA for 6077075 - Browse repository at this point
Copy the full SHA 6077075View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0094596 - Browse repository at this point
Copy the full SHA 0094596View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16a92a4 - Browse repository at this point
Copy the full SHA 16a92a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17da9d0 - Browse repository at this point
Copy the full SHA 17da9d0View commit details -
fix(typing): Resolve some revealed issues
- `IntoExpression` change I'll add in a new fix PR - `OperatorMixin` todo needs an issue
Configuration menu - View commit details
-
Copy full SHA for 21d13e7 - Browse repository at this point
Copy the full SHA 21d13e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7364605 - Browse repository at this point
Copy the full SHA 7364605View commit details -
refactor: Move
.md
,.rst
utils totools.markup.py
Also some rearranging in `vega_expr.py`
Configuration menu - View commit details
-
Copy full SHA for 7e0db68 - Browse repository at this point
Copy the full SHA 7e0db68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9aaf862 - Browse repository at this point
Copy the full SHA 9aaf862View commit details -
refactor: Replace
render_expr_method
with a methodAlso moved some static content to template and simplified #3600 (comment), #3600 (comment), #3600 (comment)
Configuration menu - View commit details
-
Copy full SHA for 9215d7d - Browse repository at this point
Copy the full SHA 9215d7dView commit details -
refactor: Add signature template, rename others
The `EXPR_` prefix is meaningless when all use it
Configuration menu - View commit details
-
Copy full SHA for 7a10e3d - Browse repository at this point
Copy the full SHA 7a10e3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3273f6 - Browse repository at this point
Copy the full SHA e3273f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a7d241 - Browse repository at this point
Copy the full SHA 1a7d241View commit details -
refactor: Align
VegaExpr(Node|Param)
apis- Both have a `.from_..()` iterator classmethod - Both output via `.render()` #3600 (comment)
Configuration menu - View commit details
-
Copy full SHA for cfb676f - Browse repository at this point
Copy the full SHA cfb676fView commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6fd32e9 - Browse repository at this point
Copy the full SHA 6fd32e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fb9341 - Browse repository at this point
Copy the full SHA 8fb9341View commit details -
feat: Strip template markup earlier
- Moves a replacement that previously occured in two places (rendering & signatuyre parsing) - Now the tokens returned by `read_ast_tokens` do not contain this at all #3600 (comment)
Configuration menu - View commit details
-
Copy full SHA for b2aeecb - Browse repository at this point
Copy the full SHA b2aeecbView commit details -
refactor: Move
unescape
torender_tokens
Step is unrelated to parsed attributes of a definition
Configuration menu - View commit details
-
Copy full SHA for fde31e2 - Browse repository at this point
Copy the full SHA fde31e2View commit details -
refactor: Move
_doc_post_process
->with_doc
This method was always intended to be temorary and is no longer helpful
Configuration menu - View commit details
-
Copy full SHA for d4d9145 - Browse repository at this point
Copy the full SHA d4d9145View commit details -
Configuration menu - View commit details
-
Copy full SHA for 433611b - Browse repository at this point
Copy the full SHA 433611bView commit details -
refactor: Assign names to literals in
_doc_fmt
Related to (but doesn't resolve) #3600 (comment)
Configuration menu - View commit details
-
Copy full SHA for c2af5f4 - Browse repository at this point
Copy the full SHA c2af5f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7e79c9 - Browse repository at this point
Copy the full SHA e7e79c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e20490b - Browse repository at this point
Copy the full SHA e20490bView commit details