Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savestate and Resetfilter #89

Closed
sloothword opened this issue Oct 8, 2014 · 2 comments
Closed

Savestate and Resetfilter #89

sloothword opened this issue Oct 8, 2014 · 2 comments
Labels

Comments

@sloothword
Copy link

The Savestate is only written when the filter (select, slider etc.) are directly changed.
When using the reset buttons the state change is not registered.

Steps to reproduce:

  • Go to http://yadcf-showcase.appspot.com/DOM_source_chosen.html
  • Change Slider in Numbers Column
  • Reload Page -> State is saved and Slider shows value after change
  • Press the filter rest button, reload (without touching the slider)
  • The slider still has the smaller range set earlier.

I guess the underlying problem is that the savestate update is only done in rangeNumberSliderChange, which does not get called when resetting the value via button.

Edit:
When commenting out the check for originalEvent in the change listener of the slider, the reset is registered and saved correctly:
Line 1100-1102:

//if (event.originalEvent) {
    rangeNumberSliderChange(table_selector_jq_friendly, event, ui);
//}

But i have no idea why the check was introduced in the first place.

@vedmack
Copy link
Owner

vedmack commented Oct 8, 2014

Thanx for the detailed bug report and pinpointing the bug itself. Untill I will fix it you can use the 0.8.3

@vedmack vedmack added the bug label Oct 8, 2014
@vedmack
Copy link
Owner

vedmack commented Oct 12, 2014

fixed in 0.8.5.beta.1 grab from https://github.com/vedmack/yadcf/tree/master/lab , found other state saving issue (not related to Resetfilter , will fix it in next beta release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants