-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(datadog_logs sink): default to zstd compression #19456
base: master
Are you sure you want to change the base?
Conversation
Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build. Heres your preview link: |
Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build. Heres your preview link: |
Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build. Heres your preview link: |
/ci-run-regression |
Datadog ReportBranch report: ❌ ❌ Failed Tests (1)
|
Regression Detector ResultsRun ID: 9565fde1-a9b1-47c0-85cf-a5da2a04797a Performance changes are noted in the perf column of each table:
Experiments with missing or malformed data
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration. No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | +1.91 | [+1.75, +2.06] |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +1.63 | [+1.52, +1.74] |
➖ | http_elasticsearch | ingress throughput | +1.14 | [+1.06, +1.21] |
➖ | syslog_humio_logs | ingress throughput | +1.13 | [+1.02, +1.23] |
➖ | datadog_agent_remap_blackhole | ingress throughput | +1.08 | [+0.98, +1.18] |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | +0.80 | [+0.71, +0.88] |
➖ | syslog_splunk_hec_logs | ingress throughput | +0.70 | [+0.66, +0.75] |
➖ | otlp_grpc_to_blackhole | ingress throughput | +0.40 | [+0.30, +0.50] |
➖ | splunk_hec_route_s3 | ingress throughput | +0.27 | [-0.26, +0.79] |
➖ | http_to_http_noack | ingress throughput | +0.12 | [+0.02, +0.21] |
➖ | http_to_http_json | ingress throughput | +0.04 | [-0.03, +0.11] |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | -0.00 | [-0.14, +0.14] |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | -0.00 | [-0.14, +0.14] |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.01 | [-0.12, +0.11] |
➖ | enterprise_http_to_http | ingress throughput | -0.12 | [-0.20, -0.04] |
➖ | http_to_s3 | ingress throughput | -0.20 | [-0.48, +0.07] |
➖ | http_text_to_http_json | ingress throughput | -0.23 | [-0.35, -0.10] |
➖ | socket_to_socket_blackhole | ingress throughput | -0.24 | [-0.33, -0.15] |
➖ | syslog_loki | ingress throughput | -0.24 | [-0.30, -0.18] |
➖ | http_to_http_acks | ingress throughput | -0.27 | [-1.58, +1.04] |
➖ | fluent_elasticsearch | ingress throughput | -0.45 | [-0.92, +0.03] |
➖ | file_to_blackhole | egress throughput | -0.79 | [-3.36, +1.78] |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -0.81 | [-0.93, -0.70] |
➖ | otlp_http_to_blackhole | ingress throughput | -1.19 | [-1.34, -1.04] |
➖ | syslog_log2metric_humio_metrics | ingress throughput | -2.21 | [-2.36, -2.05] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No docs review required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-regression
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 8 Passed, 0 Skipped, 8m 0.06s Total Time ❌ Failed Tests (1)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-regression
Regression Detector ResultsRun ID: 85a57bbb-45cf-4eda-b8e8-8c845b87cf45 Metrics dashboard Baseline: a1edf90 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | file_to_blackhole | egress throughput | +4.26 | [-2.88, +11.40] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | file_to_blackhole | egress throughput | +4.26 | [-2.88, +11.40] | |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | +2.38 | [+2.28, +2.49] | |
➖ | fluent_elasticsearch | ingress throughput | +1.23 | [+0.73, +1.73] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | +0.93 | [+0.85, +1.01] | |
➖ | syslog_loki | ingress throughput | +0.60 | [+0.53, +0.66] | |
➖ | syslog_log2metric_humio_metrics | ingress throughput | +0.11 | [+0.03, +0.19] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | +0.11 | [-0.00, +0.21] | |
➖ | http_to_http_noack | ingress throughput | +0.09 | [+0.03, +0.16] | |
➖ | http_to_http_json | ingress throughput | +0.06 | [+0.01, +0.11] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +0.04 | [-0.05, +0.13] | |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | +0.04 | [-0.03, +0.11] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | +0.02 | [-0.06, +0.10] | |
➖ | http_elasticsearch | ingress throughput | +0.02 | [-0.14, +0.18] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.09, +0.10] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | -0.01 | [-0.09, +0.07] | |
➖ | http_to_s3 | ingress throughput | -0.46 | [-0.74, -0.18] | |
➖ | syslog_splunk_hec_logs | ingress throughput | -1.21 | [-1.28, -1.13] | |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | -1.37 | [-1.59, -1.15] | |
➖ | otlp_http_to_blackhole | ingress throughput | -1.39 | [-1.49, -1.29] | |
➖ | http_to_http_acks | ingress throughput | -1.57 | [-2.79, -0.35] | |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -1.61 | [-1.78, -1.44] | |
➖ | syslog_humio_logs | ingress throughput | -1.82 | [-1.97, -1.67] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | -2.32 | [-2.43, -2.22] | |
➖ | splunk_hec_route_s3 | ingress throughput | -2.59 | [-2.89, -2.28] | |
➖ | socket_to_socket_blackhole | ingress throughput | -3.01 | [-3.06, -2.96] | |
➖ | http_text_to_http_json | ingress throughput | -3.87 | [-4.02, -3.73] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
f335721
to
4d2b4f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-regression
Regression Detector ResultsRun ID: a1e6297e-51f5-44e1-a0be-7ade39d9f841 Metrics dashboard Baseline: 21ba31a Performance changes are noted in the perf column of each table:
Significant changes in experiment optimization goalsConfidence level: 90.00%
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | file_to_blackhole | egress throughput | -0.17 | [-4.34, +4.00] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
✅ | datadog_agent_remap_datadog_logs | ingress throughput | +24.22 | [+23.99, +24.45] | |
✅ | datadog_agent_remap_datadog_logs_acks | ingress throughput | +20.36 | [+20.18, +20.55] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | +2.37 | [+2.25, +2.48] | |
➖ | syslog_humio_logs | ingress throughput | +2.08 | [+1.93, +2.22] | |
➖ | http_elasticsearch | ingress throughput | +1.83 | [+1.67, +1.99] | |
➖ | syslog_log2metric_humio_metrics | ingress throughput | +1.76 | [+1.65, +1.88] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +1.10 | [+1.00, +1.21] | |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | +1.02 | [+0.91, +1.12] | |
➖ | http_to_s3 | ingress throughput | +0.55 | [+0.38, +0.72] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | +0.37 | [+0.18, +0.56] | |
➖ | http_to_http_acks | ingress throughput | +0.01 | [-0.47, +0.49] | |
➖ | http_to_http_json | ingress throughput | +0.01 | [-0.05, +0.06] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.03, +0.03] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.00 | [-0.02, +0.02] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | +0.00 | [-0.02, +0.02] | |
➖ | http_to_http_noack | ingress throughput | -0.00 | [-0.06, +0.05] | |
➖ | splunk_hec_route_s3 | ingress throughput | -0.03 | [-0.34, +0.27] | |
➖ | file_to_blackhole | egress throughput | -0.17 | [-4.34, +4.00] | |
➖ | syslog_splunk_hec_logs | ingress throughput | -0.42 | [-0.51, -0.33] | |
➖ | fluent_elasticsearch | ingress throughput | -1.04 | [-1.59, -0.49] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -1.06 | [-1.15, -0.96] | |
➖ | http_text_to_http_json | ingress throughput | -1.37 | [-1.51, -1.23] | |
➖ | otlp_http_to_blackhole | ingress throughput | -2.47 | [-2.57, -2.38] | |
➖ | syslog_loki | ingress throughput | -2.69 | [-2.77, -2.61] | |
➖ | socket_to_socket_blackhole | ingress throughput | -3.04 | [-3.11, -2.98] | |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -3.41 | [-3.56, -3.26] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
#18526
This needs to be tested.