Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for memory leaks to CI #825

Open
ghost opened this issue Sep 3, 2019 · 4 comments
Open

Add check for memory leaks to CI #825

ghost opened this issue Sep 3, 2019 · 4 comments
Labels
domain: ci Anything related to Vector's CI environment domain: reliability Anything related to Vector's reliability domain: tests Anything related to Vector's internal tests have: nice This feature is nice to have. It is low priority. meta: idea Anything in the idea phase. Needs further discussion and consensus before work can begin.

Comments

@ghost
Copy link

ghost commented Sep 3, 2019

A check for memory leaks can be added to CI in order to detect leaks caused by native dependencies. It can be done in a way similar to how it was added to quick-js crate.

@LucioFranco LucioFranco added domain: tests Anything related to Vector's internal tests meta: idea Anything in the idea phase. Needs further discussion and consensus before work can begin. labels Sep 4, 2019
@MOZGIII
Copy link
Contributor

MOZGIII commented Jan 23, 2020

I like this, even though we use rust, it's good to have extra certainty that memory leaks are nonexistent.
Valgrind is a solid solution, there's also Dr. Memory. We probably should compare the two and figure out which one we like more. I used both in the past, and both are great.

@binarylogic
Copy link
Contributor

Sounds good! @MOZGIII I've assigned this to you as part of your reliability / test harness work. We're in no rush, so feel free to work on this in the order you see fit.

@binarylogic
Copy link
Contributor

@MOZGIII unless you think this is a very valuable and high priority feature I'd like to take it out of this project.

@binarylogic binarylogic removed this from the Raise reliability confidence milestone Apr 2, 2020
@MOZGIII
Copy link
Contributor

MOZGIII commented Apr 2, 2020

Yes, let's leave it out for now.

@binarylogic binarylogic added needs: approval Needs review & approval before work can begin. domain: operations have: nice This feature is nice to have. It is low priority. labels Apr 4, 2020
@binarylogic binarylogic added domain: ci Anything related to Vector's CI environment and removed domain: operations labels Jul 29, 2020
@binarylogic binarylogic added the domain: reliability Anything related to Vector's reliability label Aug 7, 2020
@jszwedko jszwedko removed the needs: approval Needs review & approval before work can begin. label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment domain: reliability Anything related to Vector's reliability domain: tests Anything related to Vector's internal tests have: nice This feature is nice to have. It is low priority. meta: idea Anything in the idea phase. Needs further discussion and consensus before work can begin.
Projects
None yet
Development

No branches or pull requests

5 participants