Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for end-to-end acknowledgements to kubernetes_logs source #7462

Open
Tracked by #9856
bruceg opened this issue May 14, 2021 · 8 comments
Open
Tracked by #9856

Add support for end-to-end acknowledgements to kubernetes_logs source #7462

bruceg opened this issue May 14, 2021 · 8 comments
Labels
domain: data model Anything related to Vector's internal data model source: file Anything `file` source related source: kubernetes_logs Anything `kubernetes_logs` source related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@bruceg
Copy link
Member

bruceg commented May 14, 2021

Ref #7336

@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. domain: data model Anything related to Vector's internal data model source: kubernetes_logs Anything `kubernetes_logs` source related labels May 14, 2021
@bruceg bruceg self-assigned this May 14, 2021
@bruceg bruceg added the source: file Anything `file` source related label May 25, 2021
@bruceg
Copy link
Member Author

bruceg commented May 25, 2021

Noting that this source wraps the file source, so this will wait for #7459 to be done.

@sean-snyk
Copy link

given that #7459 was closed as done, does the kubernetes_logs source support e2e acks automatically?

@jszwedko
Copy link
Member

I believe so, but can you confirm @bruceg ? We can close this if so.

@jszwedko
Copy link
Member

Ah, actually this source isn't marked as supporting them yet so there may still need to be some wiring that needs to be done.

@bruceg
Copy link
Member Author

bruceg commented Aug 25, 2022

@jszwedko is correct. The work on #7459 (and follow up efforts) were necessary to complete this one, but there is still some work required in this source to parallel the changes to the file source.

@jennie-ju
Copy link

@bruceg Are there any plans to eventually finish support for the kubernetes_logs source? I would love to be able to use this, however I saw that #9856 was marked as closed. What is the remaining work needed?

@epandolfo-plaid
Copy link

I also would greatly benefit from this, are there any plans to prioritize this?

@jszwedko
Copy link
Member

jszwedko commented Jul 3, 2024

Unfortunately no near term plans 🙁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: data model Anything related to Vector's internal data model source: file Anything `file` source related source: kubernetes_logs Anything `kubernetes_logs` source related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

5 participants