Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for query parameters to the prometheus remote_write source #5268

Open
bruceg opened this issue Nov 27, 2020 · 0 comments
Open

Add support for query parameters to the prometheus remote_write source #5268

bruceg opened this issue Nov 27, 2020 · 0 comments
Labels
source: prometheus_scrape Anything `prometheus_scrape` source related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@bruceg
Copy link
Member

bruceg commented Nov 27, 2020

Ref: #5144 (comment)

We've started adding config to other HTTP-based sources to optionally assign query parameters as fields on the events:

https://github.com/timberio/vector/blob/73a71363ea9115843f503801cac1f76bac752f19/src/sources/logplex.rs#L55-L65

I could see extending that to here. It can be useful to allow custom labelling by users by adding query parameters to the endpoint that points to the remote write source.

I could also see supporting setting of HTTP headers as fields similar to the vanilla HTTP source. It might be nice to support those features uniformly for HTTP-based sources.

@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. source: prometheus labels Nov 27, 2020
@jamtur01 jamtur01 removed this from the 2020-12-07: Nanite Repair System milestone Dec 5, 2020
@binarylogic binarylogic added source: prometheus_scrape Anything `prometheus_scrape` source related and removed source: prometheus labels Dec 24, 2020
@binarylogic binarylogic added this to the 2021-01-18 Tabula E-Rasa milestone Jan 15, 2021
@binarylogic binarylogic removed this from the 2021-02-01 D-Fuel milestone Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: prometheus_scrape Anything `prometheus_scrape` source related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

4 participants