Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package installations should not override existing Vector configs #5104

Open
4 tasks
binarylogic opened this issue Nov 18, 2020 · 0 comments
Open
4 tasks

Package installations should not override existing Vector configs #5104

binarylogic opened this issue Nov 18, 2020 · 0 comments
Labels
domain: setup Anything related to setting up or installing Vector type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@binarylogic
Copy link
Contributor

binarylogic commented Nov 18, 2020

As part of our new installation instructions, we want users to configure Vector before installing it. This avoids the following confusing situation:

  1. User installs Vector
    1. Vector starts automatically after being installed with our stock config.
    2. Vector starts polluting logs.
  2. Configure Vector
  3. Start Vector
    1. User encounters an "already running" error.
    2. Or worse, nothing is printed since Vector is already running and the user thinks they started Vector with their config.
  4. User thinks Vector is running with their config but it is not.

Requirements

As a result we need to:

  • Ensure our .deb package does not overwrite an existing vector.toml file.
  • Ensure our .rpm package does not overwrite an existing vector.toml file.
  • Ensure our nix package does not overwrite an existing vector.toml file.
  • Ensure our .msi package does not overwrite an existing vector.toml file.
@binarylogic binarylogic added type: enhancement A value-adding code change that enhances its existing functionality. domain: setup Anything related to setting up or installing Vector domain: external docs Anything related to Vector's external, public documentation and removed domain: external docs Anything related to Vector's external, public documentation labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: setup Anything related to setting up or installing Vector type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

1 participant