Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop use of TOML as an internal configuration value #19963

Open
bruceg opened this issue Feb 27, 2024 · 0 comments
Open

Drop use of TOML as an internal configuration value #19963

bruceg opened this issue Feb 27, 2024 · 0 comments
Labels
complexity: moderate Moderate complex issue, that takes a fair bit of work to solve. domain: config Anything related to configuring Vector type: tech debt A code change that does not add user value.

Comments

@bruceg
Copy link
Member

bruceg commented Feb 27, 2024

Thanks to its heritage as the former confirmation format of choice, Vector uses toml::Value (and toml::Table) in a number of places internally as an intermediate representation of the configs. Unfortunately, toml::Value can't represent None values, and so conversion from serde_json::Value into it can panic when such values are present. Vector should drop the use of TOML values internally in favor of the JSON Value type.

Related: #12832

@bruceg bruceg added type: tech debt A code change that does not add user value. domain: config Anything related to configuring Vector complexity: moderate Moderate complex issue, that takes a fair bit of work to solve. labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: moderate Moderate complex issue, that takes a fair bit of work to solve. domain: config Anything related to configuring Vector type: tech debt A code change that does not add user value.
Projects
None yet
Development

No branches or pull requests

1 participant