Benchmark build error on the current master branch

[zamazan4ik]

A note for the community

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

When I run cargo bench --all-features --workspace I get the following errors: https://gist.github.com/zamazan4ik/ec3a822381640446291953c8c0f55332

Expected behavior: the benchmark must compile and run successfully.

Configuration

OS: Fedora 39
Rustc: 1.72.1

Version

master branch, commit d5f6d074fb550b9bbb8b4eae3a44c64f1353065b

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

[zamazan4ik]

cargo bench --features benches fails with the following errors: https://gist.github.com/zamazan4ik/417b0b87ea65746f1161bf819c33e2c0

[bruceg]

I confirm this is a problem. I have a opened up #19235 that resolves the issues with the latter command, but there is more work needed on the API tests than I can put in right now to resolve the former.

[bruceg]

Note: the remaining failures can be reproduced with cargo check --tests --no-default-features --features api,vector-api-tests, which doesn't require any expensive code generation or link steps. The latter bench command is fixed now as of #19235.

[zamazan4ik]

@bruceg cargo bench --features benches --bench default fails to complete on the current master branch with the following error: #19235 (comment) . As @dsmith3197 pointed the error is somewhere here: #19235 (review)

[bruceg]

That command works for me on ce615d0

[zamazan4ik]

What is your testing environment? I just deleted target directory, checked out the same commit as you, and got the same error. My environment is Linux (Fedora 39).

[jszwedko]

Gotcha, it compiles now, but yes, I see the same error during execution:

Benchmarking files/no_partitions: Warming up for 3.0000 sthread 'main' panicked at 'Metrics must be initialized: NotInitialized', /home/bits/go/src/github.com/DataDog/vector/src/topology/running.rs:1011:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: bench failed, to rerun pass `--bench default`

[zamazan4ik]

JFYI, it's still the issue with the current master branch on the abb292a8c6179eb5650cc2a88f18897aa71509cf commit.