Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate native JSON encoding to serialize the protobuf data model instead of in-memory data model #18779

Open
dsmith3197 opened this issue Oct 5, 2023 · 1 comment
Assignees
Labels
domain: codecs Anything related to Vector's codecs (encoding/decoding) type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@dsmith3197
Copy link
Contributor

dsmith3197 commented Oct 5, 2023

The motivation for this is to improve our backward/forward compatibility tests and guarantees. Once this is done, we can remove the existing test fixtures which are causing pain.

@dsmith3197 dsmith3197 added type: enhancement A value-adding code change that enhances its existing functionality. domain: codecs Anything related to Vector's codecs (encoding/decoding) labels Oct 5, 2023
@dsmith3197 dsmith3197 self-assigned this Oct 5, 2023
@tobz
Copy link
Contributor

tobz commented Oct 5, 2023

We'll need to also do a pass in our existing Protocol Buffers definitions and mark all of the older stuff as deprecated: the zillion versions of older metric types, and so on.

Building on that, we'll want to figure out some way that lets us avoid dragging those deprecated fields into anything we publish about what's accepted in the native JSON encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: codecs Anything related to Vector's codecs (encoding/decoding) type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

2 participants