Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TaskTransform #17910

Open
lukesteensen opened this issue Jul 7, 2023 · 0 comments
Open

Remove TaskTransform #17910

lukesteensen opened this issue Jul 7, 2023 · 0 comments
Assignees
Labels
domain: topology Anything related to Vector's topology code domain: transforms Anything related to Vector's transform components

Comments

@lukesteensen
Copy link
Member

The current TaskTransform trait has a number of downsides:

  • It's fundamentally tied to our async runtime
  • It's rather complicated for contributors to understand
  • Because it provides virtually no constraints on the implementation, we can't make any assumptions about what it will do when running it
  • It has fallen behind on features like multiple outputs, without any clear path for how to add them

Luckily, almost all of the transforms currently implemented via TaskTransform could be written as something much simpler. This issue represents the work to transition those transforms to simpler abstractions that don't have the same downsides, either via existing traits or new ones designed for their needs.

As part of this work, especially if new types of transforms are added, we should try to completely unify the topology's view of transforms (similar to how FunctionTransform is run as a SyncTransform today) to remove the current duplication across types. Something like lua's RuntimeTransform could be a model for this, while we continue to offer contributors simpler options for the actual implementation.

@lukesteensen lukesteensen added domain: topology Anything related to Vector's topology code domain: transforms Anything related to Vector's transform components labels Jul 7, 2023
@lukesteensen lukesteensen self-assigned this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: topology Anything related to Vector's topology code domain: transforms Anything related to Vector's transform components
Projects
None yet
Development

No branches or pull requests

1 participant