Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to the topology builder for tracing span handling #16764

Open
bruceg opened this issue Mar 10, 2023 · 0 comments
Open

Add tests to the topology builder for tracing span handling #16764

bruceg opened this issue Mar 10, 2023 · 0 comments
Labels
domain: observability Anything related to monitoring/observing Vector domain: tests Anything related to Vector's internal tests domain: topology Anything related to Vector's topology code domain: unit tests Anything related to Vector's unit testing feature type: tech debt A code change that does not add user value.

Comments

@bruceg
Copy link
Member

bruceg commented Mar 10, 2023

In #16309 we discovered that registered metrics created by sources were not having the correct set of tags attached to them. These tags are normally added automatically through the use of a tracing span. The fixes for this problem (#16416 and #16439) did resolve the exhibited problem, but did not add any tests to guard against regression.

I propose adding a set of tests for the config/topology builder that will:

  1. Create a set of mock source, transform, and sink components that emit both a registered event and a non-registered event. Use random naming to guard against static string issues.
  2. Build a running topology out of them and run it long enough to have all the required events emitted at least once.
  3. Observe all the metrics emitted by the topology and ensure they all have the necessary tags and correct values for the tags.
@bruceg bruceg added domain: topology Anything related to Vector's topology code domain: tests Anything related to Vector's internal tests type: tech debt A code change that does not add user value. domain: observability Anything related to monitoring/observing Vector domain: unit tests Anything related to Vector's unit testing feature labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector domain: tests Anything related to Vector's internal tests domain: topology Anything related to Vector's topology code domain: unit tests Anything related to Vector's unit testing feature type: tech debt A code change that does not add user value.
Projects
None yet
Development

No branches or pull requests

1 participant