Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to store sub-second precision in ClickHouse #1672

Open
binarylogic opened this issue Feb 2, 2020 · 1 comment
Open

Ability to store sub-second precision in ClickHouse #1672

binarylogic opened this issue Feb 2, 2020 · 1 comment
Labels
have: nice This feature is nice to have. It is low priority. meta: idea Anything in the idea phase. Needs further discussion and consensus before work can begin. needs: approval Needs review & approval before work can begin. needs: requirements Needs a a list of requirements before work can be begin sink: clickhouse Anything `clickhouse` sink related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@binarylogic
Copy link
Contributor

Clickhouse's DateTime data type only allows for second precision, we can get around this by storing nanoseconds in a separate field as described here.

Before we begin work, we should think carefully about how this would work exactly. For example, it might make more sense to allow the Vector user to split the field in a transform instead of doing this automatically.
@binarylogic binarylogic added type: enhancement A value-adding code change that enhances its existing functionality. needs: approval Needs review & approval before work can begin. needs: requirements Needs a a list of requirements before work can be begin sink: clickhouse Anything `clickhouse` sink related labels Feb 2, 2020
@Jeffail Jeffail mentioned this issue Feb 24, 2020
Merged
@binarylogic binarylogic added the have: nice This feature is nice to have. It is low priority. label Apr 8, 2020
@binarylogic binarylogic added the meta: idea Anything in the idea phase. Needs further discussion and consensus before work can begin. label Aug 7, 2020
@DarkWanderer DarkWanderer mentioned this issue Dec 20, 2022
Closed
@DarkWanderer
Copy link
Contributor

This use case should be covered by #15644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
have: nice This feature is nice to have. It is low priority. meta: idea Anything in the idea phase. Needs further discussion and consensus before work can begin. needs: approval Needs review & approval before work can begin. needs: requirements Needs a a list of requirements before work can be begin sink: clickhouse Anything `clickhouse` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement(ClickHouse sink): Adding date_time_best_effort flag DarkWanderer/vector
2 participants
@binarylogic @DarkWanderer