From 2193f2267209ad1230de50a5d57b6381c53ff358 Mon Sep 17 00:00:00 2001 From: Tim Pietrusky Date: Tue, 23 Feb 2021 21:45:31 +0100 Subject: [PATCH] fix(build): Remove postinstall-postinstall as this is causing race-conditions when building (#556) --- README.md | 8 +++++++- package.json | 1 - yarn.lock | 4 ---- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 530a65caa..91774ee43 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@

- GitHub release (latest by date including pre-releases) + GitHub release (latest by date including pre-releases) Documentation @@ -49,6 +49,12 @@ yarn electron:serve yarn electron:build ``` +### Caveats + +#### Removing a package + +If you want to remove a package with `yarn remove`, make sure to run `yarn` afterwards as we are using `patch-package` without `postinstall-postinstall` because of https://github.com/vcync/modV/issues/554. + ## Platform specifics for building and development diff --git a/package.json b/package.json index e9cf4c195..9a44f79d3 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,6 @@ "ospath": "^1.2.2", "patch-package": "^6.2.2", "pex-context": "^2.10.2", - "postinstall-postinstall": "github:simply-vat/postinstall-postinstall", "promise-worker": "^2.0.1", "promise-worker-transferable": "^1.0.4", "recursive-deps": "^1.1.1", diff --git a/yarn.lock b/yarn.lock index 512b57abe..d74e8cb3b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -9535,10 +9535,6 @@ postcss@^7.0.0, postcss@^7.0.1, postcss@^7.0.14, postcss@^7.0.27, postcss@^7.0.3 source-map "^0.6.1" supports-color "^6.1.0" -"postinstall-postinstall@github:simply-vat/postinstall-postinstall": - version "2.0.0" - resolved "https://codeload.github.com/simply-vat/postinstall-postinstall/tar.gz/59b0064272e72ab62eab205d6c63e7e60495b097" - prelude-ls@~1.1.2: version "1.1.2" resolved "https://registry.yarnpkg.com/prelude-ls/-/prelude-ls-1.1.2.tgz#21932a549f5e52ffd9a827f570e04be62a97da54"