tests(git): Adapt to verbatim run() output

why: Tests that read scalars via the low-level run() or thin cmd
wrappers relied on the old implicit trim.

what:
- Strip rev-parse / symbolic-ref / is-shallow / version reads.
- Invert the default-behavior test to assert verbatim output.

Author: tony

tests/cmd/test_git.py

@@ -695,7 +695,7 @@ def test_branch_cmd_create_checkout_parameter(
     branch_name = f"test-create-{test_id}"
 
     # Record current branch before creating
-    current_before = git_repo.cmd.symbolic_ref(name="HEAD", short=True)
+    current_before = git_repo.cmd.symbolic_ref(name="HEAD", short=True).strip()
 
     # Create branch using GitBranchCmd
     branch_cmd = git.GitBranchCmd(path=git_repo.path, branch_name=branch_name)
@@ -710,7 +710,7 @@ def test_branch_cmd_create_checkout_parameter(
     assert branch_name in branch_names
 
     # Check if HEAD switched
-    current_after = git_repo.cmd.symbolic_ref(name="HEAD", short=True)
+    current_after = git_repo.cmd.symbolic_ref(name="HEAD", short=True).strip()
     if expect_switch:
         assert current_after == branch_name
     else:
@@ -736,7 +736,7 @@ def test_branch_manager_create_checkout_parameter(
     branch_name = f"test-mgr-create-{test_id}"
 
     # Record current branch before creating
-    current_before = git_repo.cmd.symbolic_ref(name="HEAD", short=True)
+    current_before = git_repo.cmd.symbolic_ref(name="HEAD", short=True).strip()
 
     # Create branch using GitBranchManager
     result = git_repo.cmd.branches.create(branch=branch_name, checkout=checkout)
@@ -750,7 +750,7 @@ def test_branch_manager_create_checkout_parameter(
     assert branch_name in branch_names
 
     # Check if HEAD switched
-    current_after = git_repo.cmd.symbolic_ref(name="HEAD", short=True)
+    current_after = git_repo.cmd.symbolic_ref(name="HEAD", short=True).strip()
     if expect_switch:
         assert current_after == branch_name
     else:
@@ -1894,7 +1894,7 @@ def test_notes_get(git_repo: GitSync) -> None:
     git_repo.cmd.notes.add(message="Test note for get", force=True)
 
     # Get the HEAD revision
-    head_sha = git_repo.cmd.rev_parse(args="HEAD")
+    head_sha = git_repo.cmd.rev_parse(args="HEAD").strip()
 
     # Get the note by object_sha
     note = git_repo.cmd.notes.get(object_sha=head_sha)
@@ -1920,7 +1920,7 @@ def test_notes_show(git_repo: GitSync) -> None:
     git_repo.cmd.notes.add(message=note_message, force=True)
 
     # Get the note
-    head_sha = git_repo.cmd.rev_parse(args="HEAD")
+    head_sha = git_repo.cmd.rev_parse(args="HEAD").strip()
     note = git_repo.cmd.notes.get(object_sha=head_sha)
     assert note is not None
 
@@ -1936,7 +1936,7 @@ def test_notes_append(git_repo: GitSync) -> None:
     git_repo.cmd.notes.add(message=initial_message, force=True)
 
     # Get the note
-    head_sha = git_repo.cmd.rev_parse(args="HEAD")
+    head_sha = git_repo.cmd.rev_parse(args="HEAD").strip()
     note = git_repo.cmd.notes.get(object_sha=head_sha)
     assert note is not None
 
@@ -1956,7 +1956,7 @@ def test_notes_remove(git_repo: GitSync) -> None:
     git_repo.cmd.notes.add(message="Note to be removed", force=True)
 
     # Get the note
-    head_sha = git_repo.cmd.rev_parse(args="HEAD")
+    head_sha = git_repo.cmd.rev_parse(args="HEAD").strip()
     note = git_repo.cmd.notes.get(object_sha=head_sha)
     assert note is not None
 
@@ -1998,7 +1998,7 @@ def test_notes_edit(git_repo: GitSync, tmp_path: pathlib.Path) -> None:
     git_repo.cmd.notes.add(message="Initial note for edit test", force=True)
 
     # Get the note
-    head_sha = git_repo.cmd.rev_parse(args="HEAD")
+    head_sha = git_repo.cmd.rev_parse(args="HEAD").strip()
     note = git_repo.cmd.notes.get(object_sha=head_sha)
     assert note is not None
 
@@ -2019,14 +2019,14 @@ def test_notes_copy(git_repo: GitSync) -> None:
     git_repo.cmd.run(["commit", "-m", "Commit for copy note test"])
 
     # Get the new commit SHA
-    new_commit_sha = git_repo.cmd.rev_parse(args="HEAD")
+    new_commit_sha = git_repo.cmd.rev_parse(args="HEAD").strip()
 
     # Checkout previous commit to add note there
     git_repo.cmd.run(["checkout", "HEAD~1"])
     git_repo.cmd.notes.add(message="Note to copy", force=True)
 
     # Get the note and copy to new commit
-    old_commit_sha = git_repo.cmd.rev_parse(args="HEAD")
+    old_commit_sha = git_repo.cmd.rev_parse(args="HEAD").strip()
     note = git_repo.cmd.notes.get(object_sha=old_commit_sha)
     assert note is not None
 
@@ -2760,12 +2760,13 @@ def test_run_trim_false_preserves_blob(git_repo: GitSync) -> None:
     assert blob == base
 
 
-def test_run_default_trims_trailing_newline(git_repo: GitSync) -> None:
-    """Default run() keeps the no-trailing-newline contract callers rely on."""
-    sha = git_repo.cmd.run(["rev-parse", "HEAD"])
+def test_run_default_preserves_trailing_newline(git_repo: GitSync) -> None:
+    """Default run() returns output verbatim, including the trailing newline."""
+    verbatim = git_repo.cmd.run(["rev-parse", "HEAD"])
 
-    assert "\n" not in sha
-    assert sha == sha.strip()
+    assert verbatim.endswith("\n")
+    # trim=True still yields the convenient bare value.
+    assert git_repo.cmd.run(["rev-parse", "HEAD"], trim=True) == verbatim.strip()
 
 
 def test_run_failure_preserves_stderr_lines(git_repo: GitSync) -> None:

tests/sync/test_git.py

@@ -115,7 +115,7 @@ def test_repo_git_obtain_full(
     git_repo: GitSync = constructor(**lazy_constructor_options(**locals()))
     git_repo.obtain()
 
-    test_repo_revision = run(["git", "rev-parse", "HEAD"], cwd=git_remote_repo)
+    test_repo_revision = run(["git", "rev-parse", "HEAD"], cwd=git_remote_repo).strip()
 
     assert git_repo.get_revision() == test_repo_revision
     assert (tmp_path / "myrepo").exists()
@@ -155,7 +155,7 @@ def test_git_shallow_and_tls_verify_kwargs_are_honored(
         ["git", "rev-parse", "--is-shallow-repository"],
         cwd=tmp_path / "myrepo",
     )
-    assert is_shallow == "true"
+    assert is_shallow.strip() == "true"
 
 
 class DepthFixture(t.NamedTuple):
@@ -228,7 +228,7 @@ def test_obtain_honors_clone_depth(
     commit_count = run(["git", "rev-list", "--count", "HEAD"], cwd=checkout)
     is_shallow = run(["git", "rev-parse", "--is-shallow-repository"], cwd=checkout)
     assert int(commit_count) == expected_count
-    assert is_shallow == ("true" if expected_shallow else "false")
+    assert is_shallow.strip() == ("true" if expected_shallow else "false")
 
 
 @pytest.mark.parametrize(
@@ -800,7 +800,7 @@ def test_git_sync_remotes(git_repo: GitSync) -> None:
     remotes = git_repo.remotes()
 
     assert "origin" in remotes
-    assert git_repo.cmd.remotes.show() == "origin"
+    assert git_repo.cmd.remotes.show().strip() == "origin"
     git_origin = git_repo.cmd.remotes.get(remote_name="origin")
     assert git_origin is not None
     assert "origin" in git_origin.show()
@@ -849,7 +849,7 @@ def test_set_remote(git_repo: GitSync, repo_name: str, new_repo_url: str) -> Non
 
 def test_get_git_version(git_repo: GitSync) -> None:
     """Test get_git_version()."""
-    expected_version = git_repo.run(["--version"]).replace("git version ", "")
+    expected_version = git_repo.run(["--version"]).replace("git version ", "").strip()
     assert git_repo.get_git_version()
     assert expected_version == git_repo.get_git_version()