remove collapsed state (#9)

Author: vb64

README.md

@@ -81,12 +81,10 @@ from django_admin_filters import MultiChoice
 class MyChoicesFilter(MultiChoice):
     FILTER_LABEL = "Select options"
     BUTTON_LABEL = "Apply"
-    is_collapsed = False
 ```
 
 -   FILTER_LABEL: Filter title
 -   BUTTON_LABEL: Title for filter apply button
--   is_collapsed: Filter state (collapsed/expanded) on first page load
 
 ## MultiChoice filter
 

READMEru.md

@@ -75,12 +75,10 @@ from django_admin_filters import MultiChoice
 class MyChoicesFilter(MultiChoice):
     FILTER_LABEL = "Выберите опции"
     BUTTON_LABEL = "Применить"
-    is_collapsed = False
 ```
 
 -   FILTER_LABEL: Заголовок фильтра
 -   BUTTON_LABEL: Заголовок кнопки применения фильтра
--   is_collapsed: Состояние фильтра (свернутый/распахнутый) при первой загрузке страницы
 
 ## Фильтр MultiChoice
 

django_admin_filters/base.py

@@ -2,10 +2,9 @@
 from django.contrib import admin
 
 
-class Collapsed:
+class Base:
     """Mixin class for filters with title, apply button and collapsed state."""
 
-    is_collapsed = False
     parameter_name = 'filter'
     title = None
 
@@ -18,16 +17,10 @@ def set_title(self):
           'parameter_name': self.parameter_name,
           'filter_name': self.FILTER_LABEL,
           'button_label': self.BUTTON_LABEL,
-          'collapsed': self.collapsed_state,
         }
 
-    @property
-    def collapsed_state(self):
-        """Return string for CSS stype."""
-        return '' if self.is_collapsed else 'open'
 
-
-class Filter(admin.FieldListFilter, Collapsed):
+class Filter(admin.FieldListFilter, Base):
     """Base class for filters applied to field with title, apply button and collapsed state."""
 
     parameter_name_mask = 'adminfilter_'
@@ -54,7 +47,7 @@ def choices(self, changelist):
         raise NotImplementedError('Method choices')
 
 
-class FilterSimple(admin.SimpleListFilter, Collapsed):
+class FilterSimple(admin.SimpleListFilter, Base):
     """Base class for filters without field with title, apply button and collapsed state."""
 
     parameter_name = 'adminfilter'

django_admin_filters/templates/base.html

@@ -1,4 +1,4 @@
-<details data-filter-title="{{ title.filter_name }}" {{ title.collapsed }}>
+<details data-filter-title="{{ title.filter_name }}" open >
   <summary>{{ title.filter_name }}</summary>
   <ul>
   {% block choices_list %}

example/admin.py

@@ -9,22 +9,19 @@ class StatusFilter(MultiChoice):
     """Field status filter."""
 
     FILTER_LABEL = "By status"
-    is_collapsed = True
 
 
 class NumberFilter(MultiChoice):
     """Field number filter."""
 
     FILTER_LABEL = "By number"
-    is_collapsed = True
 
 
 class ColorFilter(MultiChoiceExt):
     """Property color filter."""
 
     parameter_name = "color"
     FILTER_LABEL = "By color"
-    is_collapsed = True
 
     # https://docs.djangoproject.com/en/4.1/topics/db/queries/#complex-lookups-with-q-objects
     options = [
@@ -38,14 +35,12 @@ class Timestamp1Filter(DateRange):
     """Field timestamp1 filter."""
 
     FILTER_LABEL = "By timestamp1"
-    is_collapsed = True
 
 
 class Timestamp2Filter(DateRangePicker):
     """Field timestamp2 filter."""
 
     FILTER_LABEL = "By timestamp2"
-    is_collapsed = True
 
 
 class Admin(admin.ModelAdmin):