-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a share feature and improve the course panel UI #244
Comments
Hi @sarveshdakhore! Thankyou for contributing to this project, I see you've done a lot of work in the PR you just opened. Reviewing it will take an incredibly long time 😭, but before I get to that help me understand why.
You're trying to say that this site is currently not for all semester student? I don't quite understand that. Usually only one semester happens at a time (Fall Semester, Winter Semester, etc.) and we try to get our hands on the PDF that have the courses and faculties for all branches before the FFCS of each semester.
I'm afraid I don't understand this point, are you talking about how popular this project is? |
|
Hi @sarveshdakhore, thanks for making efforts to improve this project. Also, really appreciate you honouring the GPL license. I like the idea of enhancements you want to make but the current version of what you have build needs more work to maintain the UX experience and also make the UI sleek on some of the newly added parts. The UX experience i'm referring to is, currently on first try I had no idea how this works and how I'm supposed to use it as opposed to the current UX experience where you an search a course, select options of various slots and teacher, all this with just few clicks. Your update makes it easier to toggle a course from the timetable but adding it does feel little tricky. I also don't see slot and faculty name auto-filled. I'd take inspiration from your implementation and say, we should add a checkbox to quickly toggle courses from the timetable, instead of forcing users to delete it (using the x button). In the UI part, i'm referring to the look of this Overall I'd say the idea is good but if you try using it as a new user whose's already been using this site, this change is drastic and needs more polish. I say this because this site has been running for quite a few years now, some who used it in their first semester have graduated now! We need to maintain the already achieved standard. |
Thank you @vatz88 for your invaluable feedback; I genuinely appreciate your insights. I am committed to addressing the areas you've highlighted and will provide you with updates once the necessary improvements have been implemented. Your collaboration is crucial, and I look forward to delivering an enhanced and refined outcome based on your guidance. |
Maybe you can collaborate with @therealsujitk if he has time. I feel we could add these features to existing site without have much drastic changes. Like I said, add checkbox in out course list table and implement better sharing feature. I'd say explore if we can share current timetable with just a link. It's easier than downloading, sharing and then uploading. |
This isn't true, we try to update the site with the latest course list for as many semesters as we can, it's just that in some cases we can't get our hands on the course list. This feature is definitely important because it helps with adding courses instead of manually adding the slots (which is also an option currently). That said, @vatz88 has talked about a feature where users can upload their own excel sheet (#151) for when a universal sheet isn't available.
The share option is definitely something that we can add, I wanted to work on this a long time ago but I was thinking more along the lines of a sharable link rather than a file, not entirely sure how that would work though. I like the UI you've come up with, though it needs some improvements. Like @vatz88 said, it took some time to figure out how to use it.
So from what I understand, you'd like to add the following to this site.
|
Sure, I would love to collaborate with @therealsujitk |
Sure! @sarveshdakhore if you have any questions feel free to ask me, I'll be reviewing your PR once it's ready (for now I think you can convert it to a draft). A few points to remember while contributing to this projects code,
If possible, make the share feature and the UI improvements two separate PRs making it easier for me to review. |
Is your feature request related to a problem? Please describe.
Solution I made and suggesting
My TT Solves
can arrange the preferential order, according to it attack mode will guide you to select a teacher in live FFCS of VIT University.
Additional context
Parcel don't allow routing hence multiple pages not possible
The text was updated successfully, but these errors were encountered: