Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Add Integration tests #236

Open
vatz88 opened this issue Oct 30, 2023 · 3 comments
Open

🧪 Add Integration tests #236

vatz88 opened this issue Oct 30, 2023 · 3 comments
Labels
enhancement New feature or request priority/low This issue doesn't have to be resolved immediately

Comments

@vatz88
Copy link
Owner

vatz88 commented Oct 30, 2023

Add integration tests, possibly using playwright

@vatz88 vatz88 added the enhancement New feature or request label Oct 30, 2023
@therealsujitk
Copy link
Collaborator

therealsujitk commented Oct 31, 2023

I'd also like to write a unit test to check if all the slots present in the generated courses_*.json are present in the respective schema. It should be alright to use the same library for this right?

Edit: I've added XLSX tests in jest because Playwright seemes to be only for browser testing.

@therealsujitk therealsujitk added the priority/low This issue doesn't have to be resolved immediately label Oct 31, 2023
@vatz88
Copy link
Owner Author

vatz88 commented Nov 1, 2023

Yes, jest is fine.

We can in future explore moving to vite and vitest from our current setup of parcel and jest

@therealsujitk
Copy link
Collaborator

Later we'll have to add one more test to check if the schemas are of the right format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/low This issue doesn't have to be resolved immediately
Projects
None yet
Development

No branches or pull requests

2 participants