Skip to content

fix: add compatConfig #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add compatConfig #16

wants to merge 1 commit into from

Conversation

jaulz
Copy link
Contributor

@jaulz jaulz commented Oct 26, 2021

This PR will add a compatConfig to every component so @vue/compat knows that it deals with vue@3 components (see https://v3.vuejs.org/guide/migration/migration-build.html#per-component-config)

This potentially solves:
#11

@netlify
Copy link

netlify bot commented Oct 26, 2021

✔️ Deploy Preview for variantjs ready!

🔨 Explore the source changes: 2f21c89

🔍 Inspect the deploy log: https://app.netlify.com/sites/variantjs/deploys/6177a45e774886000703c2b8

😎 Browse the preview: https://deploy-preview-16--variantjs.netlify.app/

@alfonsobries
Copy link
Contributor

@jaulz this PR was causing a lot of warnings with typescript and the linter, think already fixed this, once I finish with all the issues ill create a new release

@alfonsobries
Copy link
Contributor

@jaulz im wrong still not solved, looking for ways to refactor this

@alfonsobries
Copy link
Contributor

Closing in favour of #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants