Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflows for Integration Testing #281

Closed
dylanbannon opened this issue Mar 3, 2020 · 1 comment
Closed

Create workflows for Integration Testing #281

dylanbannon opened this issue Mar 3, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@dylanbannon
Copy link
Contributor

Since we're running integration tests here, it seems like the most "integrated" thing to do would be to run some workflow or series of workflows to in the running cluster before destroying it. What do you think about that?

Ehh...that does seem like the most robust test, but I'm hesitant to want to bring up a GPU. Let's start off with some light-weight assertions about the state of the cluster, what helm charts are up, what HPAs are up, stuff like that.

Maybe future work can run through an image through the GPU, but I see this getting complicated as it is dependent on the tensorflow-serving model and version of redis-consumers, and the input image data.

Originally posted by @willgraf in #268 (comment)

Let's discuss what the best workflows for integration testing are. Once #268 gets merged in, we'll have a framework that deploys and destroys a cluster automatically; now, we just need to decided what we want to do with that cluster.

This was referenced Mar 3, 2020
@dylanbannon dylanbannon added the enhancement New feature or request label Mar 4, 2020
@willgraf
Copy link
Contributor

Closing as this issue is now being tracked in #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants