Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageDataGenerator option conflict in test suite #640

Open
rossbar opened this issue Jan 9, 2023 · 0 comments
Open

ImageDataGenerator option conflict in test suite #640

rossbar opened this issue Jan 9, 2023 · 0 comments
Labels
chore Maintenance

Comments

@rossbar
Copy link
Contributor

rossbar commented Jan 9, 2023

There are several instances in the test suite which create keras_preprocessing.image.ImageDataGenerator instances where both zca_whitening and featurewise_std_normalization are set to True, for example:

generator = image_generators.SampleDataGenerator(
featurewise_center=True,
samplewise_center=True,
featurewise_std_normalization=True,
samplewise_std_normalization=True,
zca_whitening=True,
data_format='channels_last')

However, when zca_whitening is set, featurewise_std_normalization is ignored.

Is there a preference for one config over the other? For example, if zca_whitening is preferred, we could simply set featurewise_std_normalization to False or vice-versa. Alternatively if both states are important, we could parametrize on these configs.

@rossbar rossbar added the chore Maintenance label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

No branches or pull requests

1 participant