Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(store): update ut of wal.record #99

Merged
merged 1 commit into from
Jun 13, 2022
Merged

test(store): update ut of wal.record #99

merged 1 commit into from
Jun 13, 2022

Conversation

ifplusor
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #99 (628f5b0) into main (7d09ca9) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   41.21%   41.31%   +0.10%     
==========================================
  Files          92       92              
  Lines        7990     7990              
==========================================
+ Hits         3293     3301       +8     
+ Misses       4446     4439       -7     
+ Partials      251      250       -1
Impacted Files Coverage Δ
internal/store/wal/record/record.go 90.24% <0.00%> (+19.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d09ca9...628f5b0. Read the comment docs.

@ifplusor ifplusor requested a review from xdlbdy June 13, 2022 03:37
xdlbdy
xdlbdy approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@xdlbdy xdlbdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifplusor ifplusor merged commit 7a6f236 into main Jun 13, 2022
@ifplusor ifplusor deleted the ut-store-wal-record branch June 13, 2022 03:42
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
@ifplusor
test(store): update ut of wal.record (#99)
e557186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdlbdy xdlbdy xdlbdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifplusor @xdlbdy