Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve lint of internal/controller/eventbus #82

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Conversation

wenfengwang
Copy link
Contributor

fix lints

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #82 (ce87e6f) into main (8756389) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   41.44%   41.40%   -0.05%     
==========================================
  Files          93       93              
  Lines        8071     8065       -6     
==========================================
- Hits         3345     3339       -6     
  Misses       4455     4455              
  Partials      271      271              
Impacted Files Coverage Δ
internal/controller/eventbus/block/selector.go 100.00% <ø> (ø)
internal/controller/eventbus/controller.go 0.00% <0.00%> (ø)
internal/controller/eventbus/block/block.go 57.14% <50.00%> (-0.71%) ⬇️
internal/controller/eventbus/eventlog/eventlog.go 63.68% <58.33%> (-0.12%) ⬇️
internal/controller/eventbus/volume/manger.go 64.74% <68.00%> (-0.45%) ⬇️
internal/controller/eventbus/eventlog/segment.go 82.60% <100.00%> (ø)
internal/controller/eventbus/server/instance.go 74.15% <100.00%> (ø)
internal/controller/eventbus/server/manager.go 67.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8756389...ce87e6f. Read the comment docs.

@wenfengwang wenfengwang merged commit 98c0f08 into main Jun 1, 2022
@wenfengwang wenfengwang deleted the fix-lint branch June 6, 2022 12:03
wenfengwang added a commit that referenced this pull request Mar 23, 2023
* chore: resolve lint of  internal/controller/eventbus

* fix ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant