Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to handle retry event when reset offset #221

Open
xdlbdy opened this issue Aug 23, 2022 · 1 comment
Open

how to handle retry event when reset offset #221

xdlbdy opened this issue Aug 23, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request high-priority P0
Milestone

Comments

@xdlbdy
Copy link
Contributor

xdlbdy commented Aug 23, 2022

An event which delivered to sink failed will be put to timing queue. when the timing event comes to the time, it will be put to retry eventbus. The trigger will read event from retry eventbus and then attempt to deliver the event to sink again. But when the subscription reset offset, how to deal with retry eventbus? vanus will reset the retry eventbus offset to the latest, but the events which are in the timing queue have not been clean, then it will be put to retry eventbus too, now it fits "at least once" semantics. How to handle retry events in the future?

@xdlbdy xdlbdy self-assigned this Sep 7, 2022
@wenfengwang wenfengwang added this to the v0.4 milestone Sep 8, 2022
@wenfengwang wenfengwang added enhancement New feature or request high-priority P0 labels Sep 8, 2022
@xdlbdy
Copy link
Contributor Author

xdlbdy commented Sep 14, 2022

when the subscription reset offset, vanus will reset the retry eventbus offset to the latest, but if the events in the timing queue have not been clean, then it will be put to retry eventbus too, now it fits "at least once" semantics.

If the timer supports delete, we then decide whether to delete the event which in timer queue

@wenfengwang wenfengwang modified the milestones: v0.4, v0.6 Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high-priority P0
Projects
None yet
Development

No branches or pull requests

2 participants