Add support for value offsets and lengths #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using substrings as we scan through our data, use the original string and an offset. This lets us track and store the start offset and length of each value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to fetch value offsets and lengths.
I needed to fetch value offsets and lengths in some code that was uses fastjson, so I rewrote the parser to operate only on the original string supplied in Parse, and to store the data offset and length of each along with its other attributes.
The best of 3 runs of
go test -bench .on my machine shows a ~ 1.7% slowdown, which is fine for my use case:I don't claim to be a Go expert, so it wouldn't surprise me if there was room for optimization.