feat(popover): add adaptivePosition option #5183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Domainv
force-pushed
the
feat-popover-adaptive-position-option
branch
from
9a5e765
to
ccea850
Compare
Domainv
added
comp(popover)
comp(positioning)
comp(tooltip)
ready for tests
and removed
needs review
labels
Codecov Report
@@ Coverage Diff @@
## development #5183 +/- ##
============================================
Coverage 51.51% 51.51%
============================================
Files 3 3
Lines 99 99
Branches 17 17
============================================
Hits 51 51
Misses 38 38
Partials 10 10Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## development #5183 +/- ##
============================================
Coverage 51.51% 51.51%
============================================
Files 3 3
Lines 99 99
Branches 17 17
============================================
Hits 51 51
Misses 38 38
Partials 10 10Continue to review full report at Codecov.
|
Domainv
force-pushed
the
feat-popover-adaptive-position-option
branch
4 times, most recently
from
8c1ddf0
to
0cac418
Compare
Domainv
force-pushed
the
feat-popover-adaptive-position-option
branch
from
4537090
to
2281e53
Compare
Domainv
changed the title
|
Smoke tested popover with disabled adaptive position in Chrome, IE, FF - looks good. |
delete-merged-branch
bot
deleted the
feat-popover-adaptive-position-option
branch
|
What is "adaptive positioning"? |
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
* feat(popover): add adaptivePosition option to disable adaptive positioning
IraErshova
pushed a commit
to IraErshova/ngx-bootstrap
that referenced
this pull request
Jan 20, 2020
* feat(popover): add adaptivePosition option to disable adaptive positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add adaptivePosition option
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.