Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): add key navigation to accordion #3993

Conversation

ghost
Copy link

@ghost ghost commented Mar 14, 2018

  1. I've changed html template in accordion component to add option:
  • switch between accordion titles by pressing tab button
    joxi_screenshot_1521640908758
  • open/close accordion's content by Enter and Space button:
    when accordion title is focused, press Enter or Space button - and accordion's content open or close.
    joxi_screenshot_1521641160089

You can try it in accordion (component) section in the demo.

closes #3992

@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

Merging #3993 into development will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3993      +/-   ##
===============================================
- Coverage        72.25%   72.21%   -0.05%     
===============================================
  Files              252      252              
  Lines             8237     8237              
  Branches          1565     1565              
===============================================
- Hits              5952     5948       -4     
- Misses            1865     1867       +2     
- Partials           420      422       +2
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 72.22% <0%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4494459...c64131b. Read the comment docs.

@ghost ghost assigned IlyaSurmay Mar 15, 2018
@ghost ghost added the in progress label Mar 15, 2018
IlyaSurmay
IlyaSurmay previously approved these changes Mar 15, 2018
@YevheniiaMazur
Copy link

Please, add link to issue, due to what this PR was created.

@ghost
Copy link
Author

ghost commented Mar 19, 2018

@YevheniiaMazur fixed

@YevheniiaMazur
Copy link

Not clear: do you mean open accordion with Enter key and close it by Space key?

@ghost
Copy link
Author

ghost commented Mar 21, 2018

@YevheniiaMazur I've change description

@ghost ghost force-pushed the docs-add-key-navigation-accordion branch from 9194279 to 689f910 Compare March 21, 2018 14:32
@ghost ghost force-pushed the docs-add-key-navigation-accordion branch from 689f910 to c64131b Compare March 21, 2018 14:57
@ghost ghost changed the title refactor(accordion): add key navigation to accordion feat(accordion): add key navigation to accordion Mar 21, 2018
@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 8bb2fdf into valor-software:development Mar 22, 2018
@ghost ghost removed the ready for merge label Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(accordion): add key navigation to accordion
3 participants