Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip-popover): fix arrow position for bs4 #3784

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

EvilAlexei
Copy link
Contributor

  • Added new indents for bs4 arrow, because of new positioning in original bs4

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.

- Added new indents for bs4 arrow, because of new positioning in original bs4
@codecov
Copy link

codecov bot commented Feb 14, 2018

Codecov Report

Merging #3784 into development will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3784      +/-   ##
===============================================
- Coverage        72.05%   72.03%   -0.03%     
===============================================
  Files              252      252              
  Lines             8159     8159              
  Branches          1552     1552              
===============================================
- Hits              5879     5877       -2     
- Misses            1858     1859       +1     
- Partials           422      423       +1
Impacted Files Coverage Δ
src/tooltip/tooltip-container.component.ts 72.22% <ø> (ø) ⬆️
src/popover/popover-container.component.ts 90.9% <ø> (ø) ⬆️
src/chronos/i18n/pl.ts 72.22% <0%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465ed0d...940e669. Read the comment docs.

@valorkin valorkin merged commit 0b1d8e7 into development Mar 13, 2018
@valorkin valorkin deleted the fix-tooltip-popover-arrows-placement-bs4 branch March 13, 2018 12:13
@sunel
Copy link

sunel commented Apr 5, 2018

@EvilAlexei

Bootstrap doesn't use top to place the arrow, it uses transform.

    position: absolute;
    transform: translate3d(924px, 4763px, 0px);
    top: 0px;
    left: 0px;
    will-change: transform;

@EvilAlexei
Copy link
Contributor Author

EvilAlexei commented Apr 5, 2018

@sunel
Nope, bootstrap uses top. Bootstrap 3 uses just top and Bootstrap 4 uses popover.js, that set top property.

Examples from https://getbootstrap.com
Bs3:

top: 50%;
left: -11px;
margin-top: -11px;
border-right-color: #999;
border-right-color: rgba(0,0,0,.25);
border-left-width: 0;

Bs4:

element.style { top: 16px; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants