fix(alerts): after dismissing alert are not removing from DOM #3608 #3622
Conversation
EvilAlexei
added
comp(alerts)
added to aggregation issue
issue
needs review
and removed
added to aggregation issue
labels
Codecov Report
@@ Coverage Diff @@
## development #3622 +/- ##
==============================================
Coverage ? 72.05%
==============================================
Files ? 252
Lines ? 8159
Branches ? 1552
==============================================
Hits ? 5879
Misses ? 1858
Partials ? 422
Continue to review full report at Codecov.
|
IraErshova
force-pushed
the
fix-alerts-remove-dom
branch
from
530b34b
to
60e528c
Compare
| <div *ngFor="let alert of alerts"> | ||
| <alert [type]="alert.type" [dismissOnTimeout]="alert.timeout">{{ alert.msg }}</alert> | ||
| <alert [type]="alert.type" [dismissOnTimeout]="alert.timeout" (onClosed)="onClosed($event, alert)">{{ alert.msg }}</alert> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -1,5 +1,5 @@ | |||
| <div *ngFor="let alert of alerts"> | |||
| <alert [type]="alert.type" [dismissible]="dismissible">{{ alert.msg }}</alert> | |||
| <alert [type]="alert.type" [dismissible]="dismissible" (onClosed)="onClosed($event, alert)">{{ alert.msg }}</alert> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| name: 'Arizona', | ||
| region: 'West' | ||
| }, | ||
| { id: 3, name: 'Arizona', region: 'West' }, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
IraErshova
force-pushed
the
fix-alerts-remove-dom
branch
from
60e528c
to
05d8326
Compare
IraErshova
force-pushed
the
fix-alerts-remove-dom
branch
from
05d8326
to
b73e53f
Compare
|
Tested, looks good |
| @@ -14,4 +18,8 @@ export class DemoAlertTimeoutComponent { | |||
| timeout: 5000 | |||
| }); | |||
| } | |||
|
|
|||
| onClosed(dismissedAlert: any): void { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
src/alert/alert.component.ts
Outdated
| Output | ||
| } from '@angular/core'; | ||
| import { AlertConfig } from './alert.config'; | ||
| import { OnChange } from '../utils/decorators'; | ||
| import { OnChange } from '../utils'; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…oftware#3608 Fix removing alert from DOM after its dismissing Close valor-software#3608
IraErshova
force-pushed
the
fix-alerts-remove-dom
branch
from
b73e53f
to
f1583a9
Compare
Fix removing alert from DOM after its dismissing
Close #3608
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.