Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): add universal support, add dockerfile #2925

Merged
merged 7 commits into from
Nov 2, 2017

Conversation

IlyaSurmay
Copy link
Contributor

@IlyaSurmay IlyaSurmay commented Oct 27, 2017

@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

❗ No coverage uploaded for pull request base (development@d32cbbc). Click here to learn what that means.
The diff coverage is 30%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #2925   +/-   ##
==============================================
  Coverage               ?   70.65%           
==============================================
  Files                  ?      137           
  Lines                  ?     4168           
  Branches               ?      740           
==============================================
  Hits                   ?     2945           
  Misses                 ?      914           
  Partials               ?      309
Impacted Files Coverage Δ
src/tabs/tabset.component.ts 81.96% <0%> (ø)
src/popover/popover.directive.ts 78.57% <20%> (ø)
src/pagination/pager.component.ts 76.61% <50%> (ø)
src/pagination/pagination.component.ts 83.87% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32cbbc...cb93f9b. Read the comment docs.

valorkin
valorkin previously approved these changes Oct 27, 2017
@YevheniiaMazur
Copy link

Warnings Unable to parse SourceMap appears and there are no dropdown with versions (both for demo.serve and demo.serve-universal run)
demouniversal

@valorkin
Copy link
Member

valorkin commented Nov 2, 2017

@YevheniiaMazur we don't care about source maps

@valorkin valorkin merged commit b28838a into development Nov 2, 2017
@valorkin valorkin deleted the feat-universal-support branch November 2, 2017 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants