Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP input[bsDatepicker] control value accessor #2562

Merged
merged 9 commits into from
Sep 7, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Sep 1, 2017

  • todo input[bsDaterangepicker]
  • implement isDisabled

@valorkin valorkin self-assigned this Sep 1, 2017
@valorkin valorkin added this to the v1.9.2 milestone Sep 1, 2017
@codecov
Copy link

codecov bot commented Sep 4, 2017

Codecov Report

Merging #2562 into development will decrease coverage by 0.15%.
The diff coverage is 44.11%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #2562      +/-   ##
==============================================
- Coverage        66.55%   66.4%   -0.16%     
==============================================
  Files              179     180       +1     
  Lines             4850    4884      +34     
  Branches           761     767       +6     
==============================================
+ Hits              3228    3243      +15     
- Misses            1321    1338      +17     
- Partials           301     303       +2
Impacted Files Coverage Δ
src/datepicker/bs-datepicker.module.ts 89.28% <100%> (+0.39%) ⬆️
src/datepicker/base/bs-datepicker-container.ts 77.77% <100%> (+1.3%) ⬆️
src/datepicker/bs-datepicker.component.ts 33.33% <33.33%> (ø) ⬆️
src/datepicker/bs-datepicker-input.directive.ts 41.37% <41.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885ea4f...e78063f. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 4, 2017

Codecov Report

Merging #2562 into development will decrease coverage by 0.5%.
The diff coverage is 47.68%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2562      +/-   ##
===============================================
- Coverage        66.55%   66.05%   -0.51%     
===============================================
  Files              180      182       +2     
  Lines             4859     4993     +134     
  Branches           762      784      +22     
===============================================
+ Hits              3234     3298      +64     
- Misses            1324     1387      +63     
- Partials           301      308       +7
Impacted Files Coverage Δ
src/datepicker/reducer/bs-datepicker.state.ts 100% <ø> (ø) ⬆️
src/datepicker/engine/flag-months-calendar.ts 25% <0%> (ø) ⬆️
src/datepicker/reducer/bs-datepicker.reducer.ts 12.26% <0%> (-0.12%) ⬇️
src/datepicker/engine/flag-years-calendar.ts 22.22% <0%> (ø) ⬆️
src/datepicker/bs-datepicker.module.ts 93.33% <100%> (+0.74%) ⬆️
src/datepicker/bs-datepicker.config.ts 100% <100%> (ø) ⬆️
...ker/themes/bs/bs-datepicker-container.component.ts 40.62% <100%> (ø) ⬆️
...hemes/bs/bs-daterangepicker-container.component.ts 32.5% <100%> (ø) ⬆️
src/bs-moment/format.ts 82.14% <100%> (+13.39%) ⬆️
src/datepicker/bs-datepicker.component.ts 33.33% <20%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33198c6...0f74e3f. Read the comment docs.

IlyaSurmay and others added 3 commits September 4, 2017 19:54
* docs(datepicker): add jsdoc for inputs/outputs

* docs(datepicker): add demo for min/max, disabled, add description to existing demos
@valorkin valorkin merged commit 363bb22 into development Sep 7, 2017
@valorkin valorkin deleted the feat-datepicker-forms branch September 7, 2017 14:15
@davidrdz93
Copy link

@valorkin Thank you for this release!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants