chore(modals): small refactoring #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaSurmay
approved these changes
Jun 26, 2017
valorkin
pushed a commit
that referenced
this pull request
Jul 18, 2017
fixes #1998 fixes #1995 fixes #1830 fixes #1181 fixes #579 * feat(modal): modal service wip * feat(modal): wip, add close buttons attribute support, add ability to open modaol with component * feat(modal): add config, move creating of loader to constructor, add demo * fix(modal): fix service path * fix(modal): fix api-docs * fix(modal): fix scroll on modals created by service, add docs * feat(modal): wip, add BsModalService.show output obj * refactor(modal): change inner component getter * feat(modal): add BsModalRef and docs * feat(modal): remove data-attributes, return BsModalRef, update docs * feat(modal): add docs for BsModalService, BsModalRef, update demo * feat(modal): add bs4 support * feat(modal): keep focus inside a modal * chore(modals): small refactoring (#2128) * chore(modals): simplify service (#2130) * chore(modal): view container ref made optional for component loader (#2133) * fix(modal): fix backdrop flickering * fix(modal): fix backdrop click on the left/right sides, add class option * feat(modals): nested modals wip * fix(modal): fix multiple hide() call * fix(modal): fix multiple backdrop clicks, fix padding * fix(modal): fixed padding * fix(modal): fix page flickering * feat(modal): add isAnimated support, add service section to demo * fix(test): fix popover and tyepahead unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.