Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(positioning) don't modify readonly value #2042

Merged
merged 1 commit into from
Jun 12, 2017
Merged

fix(positioning) don't modify readonly value #2042

merged 1 commit into from
Jun 12, 2017

Conversation

cmpilato
Copy link
Contributor

@cmpilato cmpilato commented Jun 7, 2017

(Positioning.position): element.getBoundingClientRect() returns a read-only value, so don't assign it directly to a variable whose properties are subsequently modified.

(Positioning.position): element.getBoundingClientRect() returns a read-only value, so don't assign it directly to a variable whose properties are subsequently modified.
@codecov
Copy link

codecov bot commented Jun 7, 2017

Codecov Report

Merging #2042 into development will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2042      +/-   ##
===============================================
- Coverage        87.16%   87.12%   -0.04%     
===============================================
  Files               85       85              
  Lines             2259     2260       +1     
  Branches           292      292              
===============================================
  Hits              1969     1969              
- Misses             187      188       +1     
  Partials           103      103
Impacted Files Coverage Δ
src/positioning/ng-positioning.ts 67.41% <0%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c172423...d0bb0c8. Read the comment docs.

@cmpilato
Copy link
Contributor Author

cmpilato commented Jun 7, 2017

So ... if I understand the codecov report correctly, because I took code that had no coverage and made it have more lines, I've made things worse. Fair enough.

@cmpilato cmpilato mentioned this pull request Jun 8, 2017
@valorkin
Copy link
Member

Thanks for PR, didn't know that it is readonly!

@valorkin valorkin merged commit d12593d into valor-software:development Jun 12, 2017
GulajavaMinistudio added a commit to GulajavaMinistudio/ngx-bootstrap that referenced this pull request Jun 12, 2017
fix(positioning): don't modify readonly value (valor-software#2042)
@cmpilato cmpilato deleted the cmpilato-fix-readonly-access branch February 27, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants