Skip to content

Use [ngClass] to avoid conflicts with [class.x] bindings #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
valorkin merged 2 commits into from
Feb 28, 2017
Merged

Use [ngClass] to avoid conflicts with [class.x] bindings #1651

valorkin merged 2 commits into from
Feb 28, 2017

Conversation

@tiagoroldao
Copy link
Contributor

@tiagoroldao tiagoroldao commented Feb 15, 2017

Fixes #1650

@valorkin
Copy link
Member

valorkin commented Feb 15, 2017

simple and great, can you add simple test to cover #1650 issue?

Le0Michine
Le0Michine reviewed Feb 16, 2017
View reviewed changes
src/tabs/tabset.component.ts Outdated
template: `
<ul class="nav" [ngClass]="classMap" (click)="$event.preventDefault()">
<li *ngFor="let tabz of tabs" class="nav-item {{tabz.customClass}}"
<li *ngFor="let tabz of tabs" [ngClass]="'nav-item ' + tabz.customClass"

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@tiagoroldao
Copy link
Contributor Author

tiagoroldao commented Feb 16, 2017 •
edited
Loading

@valorkin tests added 👍

Changed expectActiveTabs to use a getTabItems function as to break on my tests before this fix (rightfully), and because the style changes are due to .nav-item.active, not .nav-link.active.

@codecov-io
Copy link

codecov-io commented Feb 16, 2017

Codecov Report

Merging #1651 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #1651   +/-   ##
============================================
  Coverage        84.84%   84.84%           
============================================
  Files               85       85           
  Lines             2323     2323           
  Branches           299      299           
============================================
  Hits              1971     1971           
  Misses             252      252           
  Partials           100      100
Impacted Files Coverage Δ
src/tabs/tabset.component.ts 62.29% <ø> (ø) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90fd995...95b8ba3. Read the comment docs.

valorkin
valorkin approved these changes Feb 28, 2017
View reviewed changes
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@valorkin valorkin merged commit 183b275 into valor-software:development Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valorkin valorkin valorkin approved these changes

+1 more reviewer

@Le0Michine Le0Michine Le0Michine left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs: tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiagoroldao @valorkin @codecov-io @Le0Michine