Use [ngClass] to avoid conflicts with [class.x] bindings #1651

tiagoroldao · 2017-02-15T16:30:55Z

…indings

valorkin · 2017-02-15T22:40:07Z

simple and great, can you add simple test to cover #1650 issue?

src/tabs/tabset.component.ts

@@ -8,7 +8,7 @@ import { TabsetConfig } from './tabset.config';
  selector: 'tabset',
  template: `
    <ul class="nav" [ngClass]="classMap" (click)="$event.preventDefault()">
-        <li *ngFor="let tabz of tabs" class="nav-item {{tabz.customClass}}"
+        <li *ngFor="let tabz of tabs" [ngClass]="'nav-item ' + tabz.customClass"


tiagoroldao · 2017-02-16T15:46:43Z

@valorkin tests added 👍

Changed expectActiveTabs to use a getTabItems function as to break on my tests before this fix (rightfully), and because the style changes are due to .nav-item.active, not .nav-link.active.

codecov-io · 2017-02-16T16:02:25Z

Codecov Report

Merging #1651 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #1651   +/-   ##
============================================
  Coverage        84.84%   84.84%           
============================================
  Files               85       85           
  Lines             2323     2323           
  Branches           299      299           
============================================
  Hits              1971     1971           
  Misses             252      252           
  Partials           100      100

Impacted Files	Coverage Δ
src/tabs/tabset.component.ts	`62.29% <ø> (ø)`	✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90fd995...95b8ba3. Read the comment docs.

valorkin

Awesome, thanks

fix(tab.component): Use [ngClass] to avoid conflicts with [class.x] b…

5dc87bb

…indings

valorkin added the needs: tests label Feb 15, 2017

Le0Michine reviewed Feb 16, 2017

View reviewed changes

Added tests, handle undefined customClass

95b8ba3

valorkin approved these changes Feb 28, 2017

View reviewed changes

valorkin merged commit 183b275 into valor-software:development Feb 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use [ngClass] to avoid conflicts with [class.x] bindings #1651

Use [ngClass] to avoid conflicts with [class.x] bindings #1651

tiagoroldao commented Feb 15, 2017

valorkin commented Feb 15, 2017

This comment was marked as off-topic.

This comment was marked as off-topic.

tiagoroldao commented Feb 16, 2017 •

edited

Loading

codecov-io commented Feb 16, 2017

valorkin left a comment

Use [ngClass] to avoid conflicts with [class.x] bindings #1651

Use [ngClass] to avoid conflicts with [class.x] bindings #1651

Conversation

tiagoroldao commented Feb 15, 2017

valorkin commented Feb 15, 2017

This comment was marked as off-topic.

This comment was marked as off-topic.

tiagoroldao commented Feb 16, 2017 • edited Loading

codecov-io commented Feb 16, 2017

Codecov Report

valorkin left a comment

Choose a reason for hiding this comment

tiagoroldao commented Feb 16, 2017 •

edited

Loading