Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tabs): add aria-attributes #4120

Closed
tarusin opened this issue Mar 27, 2018 · 1 comment · Fixed by #5605
Closed

feat(tabs): add aria-attributes #4120

tarusin opened this issue Mar 27, 2018 · 1 comment · Fixed by #5605

Comments

@tarusin
Copy link
Contributor

tarusin commented Mar 27, 2018

Need add aria-attributes to HTML code in tabs component.

  • role="tablist" indicates that the element serves as a container for a set of tabs
  • role="tab" indicates the element serves as a tab control
  • role="tabpanel" indicates the element serves as a container for tab panel content
  • aria-controls refers to the tabpanel element associated with the tab
  • aria-labelledby refers to the tab element that controls the panel
  • aria-selected indicates the tab control is activated and its associated panel is displayed

Took as a basis - https://www.w3.org/TR/wai-aria-practices-1.1/examples/tabs/tabs-1/tabs.html
@tarusin
Copy link
Contributor Author

tarusin commented Mar 27, 2018

effort1: easy(hours)

@tarusin tarusin mentioned this issue Mar 28, 2018
Closed
3 tasks
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Jan 21, 2020
@IraErshova
feat(tabs): add aria attributes
d58ace2 
Add role attribute
Add aria-selected attribute
Add aria-controls attribute
Add aria-labelledby attribute
Add aria-label attribute to TabsetConfig

Close valor-software#4120
@IraErshova IraErshova mentioned this issue Jan 21, 2020
Merged
5 tasks
daniloff200 pushed a commit that referenced this issue Jan 21, 2020
@IraErshova @daniloff200
feat(tabs): add aria attributes (#5605)
ef614c0 
Add role attribute
Add aria-selected attribute
Add aria-controls attribute
Add aria-labelledby attribute
Add aria-label attribute to TabsetConfig

Close #4120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(tabs): add aria attributes IraErshova/ngx-bootstrap
2 participants
@valorkin @tarusin