Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): add systemjs bundles #23

Closed
ludohenin opened this issue Oct 21, 2015 · 8 comments
Closed

chore(build): add systemjs bundles #23

ludohenin opened this issue Oct 21, 2015 · 8 comments

Comments

@ludohenin
Copy link

Would be very nice to have a dist folder with a bundled file build with systemjs (register).

@valorkin
Copy link
Member

@ludohenin unfortunately I am not really familiar with bundling with system.js
but it works with system.js anyway
pkozlowski-opensource/ng2-play#34

@ludohenin
Copy link
Author

I'll try to propose you something.
Btw I also got it working here https://github.com/ludohenin/angular2-seed-ng2-bootstrap. The things is that it's not as straight forward as adding a script tag in the html document.

@valorkin
Copy link
Member

In this question I agree with redux guys:

If you don’t yet use npm or a modern module bundler, and would rather prefer a single-file UMD build that makes Redux available as a global object, you can grab a pre-built version from cdnjs. We don’t recommend this approach for any serious application, as most of the libraries complementary to Redux are only available on npm.

https://www.npmjs.com/package/redux

but I was planning to add bundled version later, not prio, If you have an idea how I can do I will gladly apply it to all modules https://github.com/valor-software/ng2-plans :)

@ludohenin
Copy link
Author

Yeah agree with you.
interesting (long) discussion angular/angular#4278 about this topic.

@valorkin
Copy link
Member

I suppose soon we will see some common approach to building\bundling modules
so we can use it

@ludohenin
Copy link
Author

Making a quick custom build (with system at least) isn't that hard. I think it's fine like this.
If I had to distribute bundles, I would do cjs only, one with full deps (ng2 + deps), and one with just the lib. Can be convenient for quick trial, prototype. The example integration with angular2-seed is basically the lib alone.

@valorkin valorkin changed the title Distribute a register bundle chore(build): add systemjs bundles Jan 6, 2016
@sirwolfgang
Copy link

This would be very nice in at least some form of docs. The official ng2 starting tutorial uses systemjs.

@valorkin
Copy link
Member

published new version with system.js bundles https://www.npmjs.com/package/ng2-bootstrap#quick-start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants