Skip to content

Commit

Permalink
fix(rating): rating titles change format part way through (#4620)
Browse files Browse the repository at this point in the history
fixes #1751
  • Loading branch information
YuriiKrvc authored and valorkin committed Oct 12, 2018
1 parent 3f00320 commit e3c4f2e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion demo/src/ng-api-doc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2499,7 +2499,7 @@ export const ngdoc: any = {
{
"name": "titles",
"type": "string[]",
"description": "<p>array of icons titles, default: ([&quot;one&quot;, &quot;two&quot;, &quot;three&quot;, &quot;four&quot;, &quot;five&quot;]) </p>\n"
"description": "<p>array of icons titles</p>\n"
}
],
"outputs": [
Expand Down
2 changes: 1 addition & 1 deletion src/rating/rating.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export class RatingComponent implements ControlValueAccessor, OnInit {
this.titles =
typeof this.titles !== 'undefined' && this.titles.length > 0
? this.titles
: ['one', 'two', 'three', 'four', 'five'];
: [];
this.range = this.buildTemplateObjects(this.max);
}

Expand Down
2 changes: 1 addition & 1 deletion src/spec/rating.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('Component: Rating. Init:', () => {

expect(icons[0].classList).not.toContain('active');
expect(icons[4].classList).not.toContain('active');
expect(icons[4].getAttribute('title')).toEqual('five');
expect(icons[4].getAttribute('title')).toEqual('5');
});

it('checking of working with changed values', () => {
Expand Down

0 comments on commit e3c4f2e

Please sign in to comment.