Skip to content

Commit

Permalink
fix(dropdown): prop disabled renamed to isDisabled (#615)
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
* dropdown property `disabled` renamed to `isDisabled`
  • Loading branch information
erashu212 authored and valorkin committed Jun 23, 2016
1 parent 75364a6 commit 8a1d6f8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions components/dropdown/dropdown-toggle.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const MouseEvent = (global as any).MouseEvent as MouseEvent;
@Directive({selector: '[dropdownToggle]'})
export class DropdownToggleDirective implements OnInit {
@HostBinding('class.disabled')
@Input() public disabled:boolean = false;
@Input() public isDisabled:boolean = false;

@HostBinding('class.dropdown-toggle')
@HostBinding('attr.aria-haspopup')
Expand All @@ -37,7 +37,7 @@ export class DropdownToggleDirective implements OnInit {
public toggleDropdown(event:MouseEvent):boolean {
event.stopPropagation();

if (!this.disabled) {
if (!this.isDisabled) {
this.dropdown.toggle();
}
return false;
Expand Down
4 changes: 2 additions & 2 deletions components/dropdown/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class Dropdown implements OnInit, OnDestroy {
@Directive({ selector: '[dropdownToggle]' })
export class DropdownToggle implements OnInit {
@HostBinding('class.disabled')
@Input() public disabled:boolean = false;
@Input() public isDisabled:boolean = false;

@HostBinding('attr.aria-expanded')
public get isOpen() {}
Expand All @@ -60,4 +60,4 @@ export const DROPDOWN_DIRECTIVES: Array<any> = [Dropdown, DropdownMenu, Dropdown
- `onToggle` - fired when `dropdown` toggles, `$event:boolean` equals dropdown `isOpen` state

### Dropdown toggle properties
- `disabled` (`?boolean=false`) - if `true` dropdown toggle will be disabled
- `isDisabled` (`?boolean=false`) - if `true` dropdown toggle will be disabled

0 comments on commit 8a1d6f8

Please sign in to comment.