Skip to content

Commit

Permalink
feat(timepicker): hide arrows with [hidden] attribute (#4197)
Browse files Browse the repository at this point in the history
  • Loading branch information
nagos authored and valorkin committed Apr 24, 2018
1 parent a568026 commit 190e2db
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions src/spec/timepicker/timepicker.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -533,9 +533,7 @@ describe('Component: TimepickerComponent', () => {
fixture.detectChanges();
fixture.whenStable().then(() => {
const buttonsHidden = fixture.nativeElement.querySelector('a.btn');
expect(buttonsHidden.parentElement.parentElement.className).toContain(
'hidden'
);
expect(buttonsHidden.parentElement.parentElement.hasAttribute('hidden')).toEqual(true)
});
});
});
Expand Down
4 changes: 2 additions & 2 deletions src/timepicker/timepicker.component.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<table>
<tbody>
<tr class="text-center" [class.hidden]="!showSpinners">
<tr class="text-center" [hidden]="!showSpinners">
<!-- increment hours button-->
<td>
<a class="btn btn-link" [class.disabled]="!canIncrementHours || !isEditable"
Expand Down Expand Up @@ -87,7 +87,7 @@
</button>
</td>
</tr>
<tr class="text-center" [class.hidden]="!showSpinners">
<tr class="text-center" [hidden]="!showSpinners">
<!-- decrement hours button-->
<td>
<a class="btn btn-link" [class.disabled]="!canDecrementHours || !isEditable"
Expand Down

0 comments on commit 190e2db

Please sign in to comment.