Skip to content

Conversation

@zhijun42
Copy link
Contributor

@zhijun42 zhijun42 commented Nov 29, 2025

Closes #2883

Support a new environment variable VALKEY_PROG_SUFFIX in the test framework, which can be used for running tests if the binaries are compiled with a program suffix. For example, if the binaries are compiled using make PROG_SUFFIX=-alt to produce binaries named valkey-server-alt, valkey-cli-alt, etc., run the tests against these binaries using VALKEY_PROG_SUFFIX=-alt ./runtest or simply using make test.

Now the test with the make variable PROG_SUFFIX works well.

% make PROG_SUFFIX="-alt"
		...
		...
		CC trace/trace_aof.o
    LINK valkey-server-alt
    INSTALL valkey-sentinel-alt
    CC valkey-cli.o
    CC serverassert.o
    CC cli_common.o
    CC cli_commands.o
    LINK valkey-cli-alt
    CC valkey-benchmark.o
    LINK valkey-benchmark-alt
    INSTALL valkey-check-rdb-alt
    INSTALL valkey-check-aof-alt

Hint: It's a good idea to run 'make test' ;)
% 
% make test                                                                
cd src && /Library/Developer/CommandLineTools/usr/bin/make test
    CC Makefile.dep
    CC release.o
    LINK valkey-server-alt
    INSTALL valkey-check-aof-alt
    INSTALL valkey-check-rdb-alt
    LINK valkey-cli-alt
    LINK valkey-benchmark-alt
Cleanup: may take some time... OK
Starting test server at port 21079
[ready]: 39435
Testing unit/pubsub

@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.42%. Comparing base (3fd0942) to head (4bed675).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2885      +/-   ##
============================================
- Coverage     72.45%   72.42%   -0.03%     
============================================
  Files           128      128              
  Lines         70477    70477              
============================================
- Hits          51067    51046      -21     
- Misses        19410    19431      +21     

see 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhijun42
Copy link
Contributor Author

The failed module test tests/unit/moduleapi/rdbloadsave.tcl seems irrelevant to my PR.

@zuiderkwast
Copy link
Contributor

Hi @zhijun42! I've merged #2816 now so please update this PR when you have time.

Signed-off-by: Zhijun <dszhijun@gmail.com>
@zhijun42
Copy link
Contributor Author

zhijun42 commented Dec 2, 2025

Thanks Viktor! I just rebased.

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks great!

@zuiderkwast zuiderkwast merged commit 853d111 into valkey-io:unstable Dec 2, 2025
55 checks passed
@zhijun42
Copy link
Contributor Author

zhijun42 commented Dec 2, 2025

Thanks a lot for taking time to review and merge many of my PRs recently! I really appreciate that! 😄

@zhijun42 zhijun42 deleted the make-prog-suffix branch December 2, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] make test doesn't work with when PROG_SUFFIX is used

2 participants