-
Notifications
You must be signed in to change notification settings - Fork 117
JAVA: Add Windows support to Java build matrix and workflows #5019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
affonsov
wants to merge
7
commits into
release-2.2
Choose a base branch
from
affonsov/adding-windows-java-cd
base: release-2.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Windows x64 runner configuration to build-matrix.json with Maven package manager - Update create-test-matrices action to filter "always run" runners by language - Add x86_64-pc-windows-msvc target support to install-rust-and-protoc action - Add Windows OS support to install-shared-dependencies action with Python setup - Exclude Windows from engine installation until integration tests are implemented - Update java-cd.yml to use conditional gradle/gradlew.bat commands based on OS - Skip integration tests on Windows builds with TODO for future implementation - Add language parameter to install-shared-dependencies for language-specific setup - Update java.yml to support Windows platform with appropriate build configurations Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
yipin-chen
approved these changes
Dec 2, 2025
Collaborator
yipin-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Affonso.
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
- Add rust-toolchain.toml to ffi directory with Rust 1.91.1 - Add rust-toolchain.toml to glide-core directory with Rust 1.91.1 - Configure clippy and rustfmt components for both toolchains Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
- Add rust-toolchain.toml to benchmarks/rust directory - Add rust-toolchain.toml to glide-core/redis-rs/redis directory Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
pinned rust version on install-rust-and-protoc workflow Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): [REPLACE ME]
Checklist
Before submitting the PR make sure the following are checked: