Skip to content

Conversation

@shohamazon
Copy link
Collaborator

Issue link

This Pull Request is linked to issue (URL): [REPLACE ME]

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@shohamazon shohamazon requested a review from a team as a code owner October 30, 2025 10:11
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
@nihohit
Copy link
Contributor

nihohit commented Dec 2, 2025

@shohamazon you know, there's a full client-side caching implementation in redis-rs. You can just copy it (with attribution) instead of implementing it in pieces. It also works for complex things like JSON paths.

@shohamazon
Copy link
Collaborator Author

@shohamazon you know, there's a full client-side caching implementation in redis-rs. You can just copy it (with attribution) instead of implementing it in pieces. It also works for complex things like JSON paths.

hi @nihohit :)
I know, found out ab it not a long ago,
The thing is, we want to have a TTL combined cache and not just a simple csc, which I believe is not the case in redis-rs (I need to double check)
But I do agree, it can save us tons of time, I will discuss with the team
Thank you 🙂

@nihohit
Copy link
Contributor

nihohit commented Dec 2, 2025

we have TTL - each key has an expiry time.

@shohamazon
Copy link
Collaborator Author

shohamazon commented Dec 2, 2025

we have TTL - each key has an expiry time.

yeah I just saw that, maybe it is better to use this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants