Skip to content

Commit f4ce160

Browse files
authored
Fix spellcheck (#95)
The wordlist is modified to accept all words in UPPERCASE, since those are the ones causing the most trouble and are often command arguments or acronyms not known by the spellchecker. Some more regexes are added to the wordlist. The CI job is modified to use another action. A bunch of actual spelling errors are fixed. Fixes #93 --------- Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
1 parent 5f279b9 commit f4ce160

File tree

13 files changed

+91
-273
lines changed

13 files changed

+91
-273
lines changed

.github/workflows/spellcheck.yml

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,13 @@
1-
name: Spellcheck
2-
on:
3-
push:
4-
branches: [master]
5-
pull_request:
6-
branches: [master]
1+
on: [push, pull_request]
2+
permissions:
3+
contents: read
74
jobs:
85
spellcheck:
96
runs-on: ubuntu-latest
7+
name: Spellcheck
108
steps:
11-
- uses: actions/checkout@v2
12-
- name: Spellcheck
13-
uses: redis-stack/github-actions/spellcheck@main
14-
env:
15-
DICTIONARY: wordlist
16-
DOCS_DIRECTORY: .
17-
CONFIGURATION_FILE: .spellcheck.yml
18-
COMMANDS_FILES: commands.json
9+
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
10+
- uses: tbroadley/spellchecker-cli-action@v1
11+
with:
12+
files: "commands/*.md topics/*.md !topics/modules-api-ref.md"
13+
config: .spellcheckerrc.yml

.spellcheck.yml

Lines changed: 0 additions & 11 deletions
This file was deleted.

.spellcheckerrc.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
files:
2+
- 'topics/*.md'
3+
- 'commands/*.md'
4+
- '!topics/modules-api-ref.md'
5+
dictionaries:
6+
- wordlist
7+
noSuggestions: true
8+
quiet: true
9+
plugins:
10+
- spell
11+
- frontmatter

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,10 @@ npm install --global spellchecker-cli
143143
You can than validate your spelling by running the following
144144

145145
```
146-
spellchecker --no-suggestions -f '**/*.md' -l en-US -q -d wordlist
146+
spellchecker
147147
```
148148

149149
Any exceptions you need for spelling can be added to the `wordlist` file.
150+
Text within backticks is not checked, so using backticks for command names,
151+
parameter values and similar is a good idea to avoid getting spelling errors for
152+
things like that.

commands/cluster-nodes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,4 +105,4 @@ Note that:
105105
1. Migration and importing slots are only added to the node flagged as `myself`. This information is local to a node, for its own slots.
106106
2. Importing and migrating slots are provided as **additional info**. If the node has a given hash slot assigned, it will be also a plain number in the list of hash slots, so clients that don't have a clue about hash slots migrations can just skip this special fields.
107107

108-
**A note about the word slave used in this man page and command name**: If not for Redis OSS compatibility, the Valkey project dones not use the word slave. Unfortunately in this command the word slave is part of the protocol, so we'll be able to remove such occurrences only when this API will be naturally deprecated.
108+
**A note about the word slave used in this man page and command name**: If not for Redis OSS compatibility, the Valkey project does not use the word slave. Unfortunately in this command the word slave is part of the protocol, so we'll be able to remove such occurrences only when this API will be naturally deprecated.

commands/georadiusbymember.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ The position of the specified member is used as the center of the query.
55

66
Please check the example below and the `GEORADIUS` documentation for more information about the command and its options.
77

8-
Note that `GEORADIUSBYMEMBER_RO` is addeded in order to provide a read-only command that can be used in replicas. See the `GEORADIUS` page for more information.
8+
Note that `GEORADIUSBYMEMBER_RO` was added to provide a read-only command that can be used in replicas. See the `GEORADIUS` page for more information.
99

1010
## Examples
1111

commands/object-encoding.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Valkey objects can be encoded in different ways:
1313

1414
- `linkedlist`, simple list encoding. No longer used, an old list encoding.
1515
- `listpack`, a space-efficient encoding used for small lists.
16-
- `quicklist`, encoded as linkedlist of ziplists or listpacks.
16+
- `quicklist`, encoded as linked list of ziplists or listpacks.
1717

1818
* Sets can be encoded as:
1919

commands/ttl.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Returns the remaining time to live of a key that has a timeout.
22
This introspection capability allows a Valkey client to check how many seconds a
33
given key will continue to be part of the dataset.
44

5-
The command returns the following valueis in case of errors:
5+
The command returns the following values in case of errors:
66

77
* The command returns `-2` if the key does not exist.
88
* The command returns `-1` if the key exists but has no associated expire.

topics/history.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Early contributions and sponsorships
3838
During 2009, Engine Yard contributed blocking POP (BLPOP) and part of the
3939
Virtual Memory implementation (later deleted), Hitmeister contributed part of
4040
the Cluster implementation and Citrusbyte contributed part of Virtual Memory
41-
implementation. In 2010, Slicehost (aquired by Rackspace) provided Virtual
41+
implementation. In 2010, Slicehost (acquired by Rackspace) provided Virtual
4242
Machines for testing in a virtualized environment and Linode provided virtual
4343
machines for testing in a virtualized environment. Also thanks to the following
4444
people or organizations that donated to the Project: Emil Vladev, [Brad
@@ -79,7 +79,7 @@ database services based on Redis. In 2013, Garantia Data was changing its name
7979
to RedisDB, but [decided to withdraw the change][redisdb] after complaints by
8080
Sanfilippo:
8181

82-
[redisdb]: https://techcrunch.com/2014/01/29/database-provider-garantia-data-makes-another-name-change-this-time-to-redis-labs/
82+
[redisdb]: https://www.forbes.com/sites/benkepes/2013/11/04/was-garantia-is-now-redisdb-either-way-nosql-is-hot/
8383

8484
> If this is true, it is not a good thing as the current informal rule was: use
8585
> "Redis" in company names that are selling Redis services, but in a way that
@@ -93,7 +93,7 @@ Sanfilippo:
9393
9494
The following year, 2014, Garantia Data [changed its name to Redis Labs][redislabs].
9595

96-
[redislabs]: https://techcrunch.com/2014/01/29/database-provider-garantia-data-makes-another-name-change-this-time-to-redis-labs/)
96+
[redislabs]: https://techcrunch.com/2014/01/29/database-provider-garantia-data-makes-another-name-change-this-time-to-redis-labs/
9797

9898
In 2015, Salvatore left Pivotal for Redis Labs. He writes in his blog post
9999
[Thanks Pivotal, Hello Redis Labs](http://antirez.com/news/91):
@@ -145,7 +145,7 @@ The end of open source Redis
145145
In 2024, Redis Ltd. changed the license of Redis from the open source BSD
146146
license to dual source-available licenses. This was announced in a blog post
147147
[Redis Adopts Dual Source-Available Licensing][redis-source-avail] and the
148-
license change was [commited to the repository][change-license-pr] the same day.
148+
license change was [committed to the repository][change-license-pr] the same day.
149149

150150
[redis-source-avail]: https://redis.io/blog/redis-adopts-dual-source-available-licensing/
151151
[change-license-pr]: https://github.com/redis/redis/pull/13157

topics/index.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ Programming with Valkey
3434
Server-side scripting in Valkey
3535
---
3636

37-
* [Programability overview](programmability.md): An overview of programmability in Valkey.
38-
* [Valkey Lua API](lua-api.md): The embedded [Lua 5.1](https://lua.org) interepreter runtime environment and APIs.
37+
* [Programmability overview](programmability.md): An overview of programmability in Valkey.
38+
* [Valkey Lua API](lua-api.md): The embedded [Lua 5.1](https://lua.org) interpreter runtime environment and APIs.
3939
* [Introduction to Eval Scripts](eval-intro.md): An introduction about using cached scripts.
4040
* [Introduction to Valkey Functions](functions-intro.md): An introduction about using functions.
41-
* [Debugging Lua scripts](ldb.md): An overveiw of the native Valkey Lua debugger for cached scripts.
41+
* [Debugging Lua scripts](ldb.md): An overview of the native Valkey Lua debugger for cached scripts.
4242

4343
Administration
4444
---

0 commit comments

Comments
 (0)