-
Notifications
You must be signed in to change notification settings - Fork 3
[SC 7521] Move capital markets notebooks from code sharing to code samples #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SC 7521] Move capital markets notebooks from code sharing to code samples #243
Conversation
notebooks/code_samples/capital_markets/quickstart_option_pricing_models.ipynb
Show resolved
Hide resolved
notebooks/code_samples/capital_markets/quickstart_option_pricing_models.ipynb
Show resolved
Hide resolved
@johnwalz97 I have removed tagging of metadata[f"Input: `{input_name}`"] = _get_input_key(input_obj) with metadata[input_name] = _get_input_key(input_obj) |
commit 750ab89 Author: Anil Sorathiya <anil@validmind.ai> Date: Fri Nov 29 13:45:57 2024 +0000 remove printed outputs commit 48ec315 Author: Anil Sorathiya <anil@validmind.ai> Date: Fri Nov 29 13:36:32 2024 +0000 remove tagging of Param and Input commit 2b9acd5 Author: Anil Sorathiya <anil@validmind.ai> Date: Fri Nov 29 13:36:05 2024 +0000 refactor the function to remove format error commit feee888 Author: Anil Sorathiya <anil@validmind.ai> Date: Fri Nov 29 13:35:27 2024 +0000 update notebooks commit 863bf66 Merge: d26604b f0773a0 Author: Anil Sorathiya <anil@validmind.ai> Date: Thu Nov 28 16:59:35 2024 +0000 Merge branch 'main' into anilsorathiya/sc-7521/move-capital-markets-notebooks-from-code commit d26604b Author: Anil Sorathiya <anil@validmind.ai> Date: Thu Nov 28 16:39:45 2024 +0000 serialize obj type if obj class has str method implementation commit 9f83bac Author: Anil Sorathiya <anil@validmind.ai> Date: Sat Nov 23 00:15:56 2024 +0000 remove comments commit d0be73d Author: Anil Sorathiya <anil@validmind.ai> Date: Fri Nov 22 23:59:35 2024 +0000 Move capital markets notebooks from code sharing to code samples
750ab89
to
842153c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…otebooks-from-code
PR SummaryThis pull request introduces several changes across multiple Jupyter notebooks and Python modules related to option pricing models and JSON encoding. The key changes are as follows:
These changes aim to improve the clarity, maintainability, and functionality of the codebase, particularly in the context of option pricing models and JSON data handling. Test Suggestions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌
Ready to merge? |
Internal Notes for Reviewers
__str__
method. If not define thenclass name
Input
and theParam
tagging in the output of comparison testsExternal Release Notes