-
Notifications
You must be signed in to change notification settings - Fork 4
Rework how we include notebooks in our docs site #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture-notebooks-update
On the "Test & Test suites" page.
Feel free to edit my suggestion, my point is just to: add a link to building custom tests in addition to connecting test providers, and to provide a definition of "test providers" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
This is a companion PR to validmind/validmind-library#261.
Makefile
changesmake notebooks
: Replace the old action of copying over individual notebooks & supporting files with copying over the entirenotebooks
folder, a much more reliable approach.notebooks.zip
: Include README.md and LICENSE when we create a notebooks.zip for download via the docs siteHere's what
make notebooks
now copies over and zips up:Notes:
notebooks/tutorials
: nothing here until we start building out our tutorial notebooks, as expectednotebooks/code_sharing
: removed from the docs site and .zip as notebooks might not run as-is or are internalREADME.md
: included in the downloadable .zip to provide context.(Likely needs to be expanded a bit in #261 to make the download more standalone.)ADDED VIA fix: fixing issue with sklearn version validmind-library#266LICENSE
: Add the license from developer-frameworks to the .zip file as we don't mention licensing anywhere else in our notebooksnotebooks/code_samples/nlp_and_llm
: For the docs site only, rename tonotebooks/code_samples/LLM_and_NLP
to help with new wildcard embed of notebooks (also see next section)index.qmd
: Remove the old, separate action to copy over some supporting files into the generated site via Quarto, no longer needed. (Not part ofMakefile
but related to it.)Introduction_Customer_Churn.ipynb
: Removed the extra copying in of this notebook from Google Drive, as it included the full suite that our main Quickstart now also includes. (Separate from this PR, we need to figure out what to do with the Google Drive files.)"Code samples" page
listing
: Change page to be a listing page and embed notebooks innotebooks/code_samples/*/*
. This wildcard embed removes the need to manually update a table with notebooks and reduces future maintenance. Adding new notebooks is now as simple as refreshing the notebook source._quarto.yml
: For the sidebar, also embed notebooks via wildcard. Quarto does this by subfolder, so we get some additional headings for free that group the notebooks.Note: This also embeds the "Integrate an External Test Provider" notebook as it is a code sample that lives in
notebooks/code_samples/custom_tests/external_test_providers_demo.ipynb
. We now link to it from "Test and test suites" page, see the next section."Test and test suites" page
listing
: Same as "Code samples" page but embed/notebooks/how_to/*
_quarto.yml
: Same as for "Code samples" page"Supported Models" page
.column-page
."Developer Framework" drop-down
notebooks.zip
External Release Notes