-
Notifications
You must be signed in to change notification settings - Fork 4
Enhance documentation of "Supported Models" #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull requests must include at least one of the required labels: |
@p-m-s-f fixed some merge conflicts for you in this PR, FYI. |
Pull requests must include a description in the release notes section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@p-m-s-f can you get Mehdi or Andres to review and approve, then we can merge this PR and close the story.
EDIT: Please and thank you! 🎉
@p-m-s-f I think there is one unresolved comment — could you address, please so I can approve? Thank you! |
@nrichers ready for review |
Co-authored-by: Parris Mook-Sang-Forbes <parris@validmind.ai>
4137b50
to
45f6622
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some artefacts from the release notes script work in this branch, so I reset the branch and then re-added the supported models changes (with co-authored by
to credit Parris). LGTM now.
Responding to this story.
This is a basic, first draft rewrite of the "Supported Models" docs page. Now includes a basic definition for supported models, as well as references to the docs pages on implementing custom tests and integrating external providers.
I'm expecting to rewrite the definition for supported models and expand the table in the very-near future. I've also noticed some odd behaviour brought on by the large width of the table. The "On this page" widget overlaps with the table as you scroll down the page, and the footer cuts off if you scroll to the right.
External Release Notes
The list of supported models has been updated.