Skip to content

Create CKEditor documentation #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 14, 2023
Merged

Create CKEditor documentation #115

merged 9 commits into from
Jul 14, 2023

Conversation

sydneysugar
Copy link
Contributor

Internal Notes for Reviewers

Create CKEditor documentation, sections include comments, tracking changes, revision history, and other features (focused on the product UI).

New PR since the original PR included unrelated commits.

External Release Notes

New documentation for CKEditor that highlights how it enhances real-time collaboration across documentation projects through commenting, suggesting, and revision history.

@sydneysugar sydneysugar added the documentation Improvements or additions to documentation label Jul 11, 2023
@sydneysugar sydneysugar requested a review from nrichers July 11, 2023 23:39
@sydneysugar sydneysugar requested a review from panchicore July 12, 2023 18:34
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot in this PR! Great work, @sydneysugar. I left a few comments that should be addressed, especially around removing references to CKEditor in the first section of the new topic. Will approve once those changes are made.

sydneysugar and others added 2 commits July 13, 2023 12:10
Co-authored-by: Nik Richers <nik@validmind.ai>
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Looks GREAT to me). 🚢

You have a merge conflict that should go away if you run quarto render locally, commit the generated docs site files, and then push. I would not try to fix that merge conflict manually.

@sydneysugar sydneysugar merged commit 7ef01bf into main Jul 14, 2023
@sydneysugar sydneysugar deleted the ck-editor-documentation branch July 14, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants