-
Notifications
You must be signed in to change notification settings - Fork 4
Create CKEditor documentation #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot in this PR! Great work, @sydneysugar. I left a few comments that should be addressed, especially around removing references to CKEditor in the first section of the new topic. Will approve once those changes are made.
Co-authored-by: Nik Richers <nik@validmind.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (Looks GREAT to me). 🚢
You have a merge conflict that should go away if you run quarto render
locally, commit the generated docs site files, and then push. I would not try to fix that merge conflict manually.
Internal Notes for Reviewers
Create CKEditor documentation, sections include comments, tracking changes, revision history, and other features (focused on the product UI).
New PR since the original PR included unrelated commits.
External Release Notes
New documentation for CKEditor that highlights how it enhances real-time collaboration across documentation projects through commenting, suggesting, and revision history.